[PATCH v7 01/24] drm/gpuvm: Pass map arguments through a struct

Ghimiray, Himal Prasad himal.prasad.ghimiray at intel.com
Mon Aug 18 18:12:53 UTC 2025



On 18-08-2025 22:57, Danilo Krummrich wrote:
> On Thu Aug 14, 2025 at 12:59 PM CEST, Himal Prasad Ghimiray wrote:
>> From: Boris Brezillon <boris.brezillon at collabora.com>
>>
>> We are about to pass more arguments to drm_gpuvm_sm_map[_ops_create](),
>> so, before we do that, let's pass arguments through a struct instead
>> of changing each call site every time a new optional argument is added.
>>
>> v5
>>   - Use drm_gpuva_op_map—same as drm_gpuvm_map_req
>>   - Rebase changes for drm_gpuvm_sm_map_exec_lock()
>>   - Fix kernel-docs
>>
>> v6
>>   - Use drm_gpuvm_map_req (Danilo/Matt)
>>
>> v7
>>   - change member name to map instead of op_map
>>   - use local variable to minize the code changes in _sm_map
> 
> I know it's a thing in DRM, but I'd rather not have the version changes in the
> commit message. Please move them below "---" or into the cover letter.
> 
> (No need to resend for this. :)

Sure. Thanks

> 
>> Cc: Danilo Krummrich <dakr at kernel.org>
>> Cc: Brendan King <Brendan.King at imgtec.com>
>> Cc: Boris Brezillon <bbrezillon at kernel.org>
>> Cc: Caterina Shablia <caterina.shablia at collabora.com>
>> Cc: Rob Clark <robin.clark at oss.qualcomm.com>
>> Cc: Matthew Brost <matthew.brost at intel.com>
>> Cc: <dri-devel at lists.freedesktop.org>
>> Co-developed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
>> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
>> Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
>> Acked-by: Danilo Krummrich <dakr at kernel.org> #v4
>> Reviewed-by: Matthew Brost <matthew.brost at intel.com> #v6



More information about the Intel-xe mailing list