✗ CI.checkpatch: warning for drm/xe: Add psmi support (rev4)

Patchwork patchwork at emeril.freedesktop.org
Mon Aug 18 19:50:31 UTC 2025


== Series Details ==

Series: drm/xe: Add psmi support (rev4)
URL   : https://patchwork.freedesktop.org/series/151729/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
553439844b6500767ce8aef522cfe9fbb7ece541
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 937127c1b58598a82248b50d2959270871f6c92c
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date:   Mon Aug 18 10:37:38 2025 -0700

    drm/xe/configfs: Dump custom settings when binding
    
    Device configuration using configfs could be prepared long time prior
    the driver load. Currently all the xe configfs entries are for things
    that are important to have in the log if a non-default value is being
    used. Add a info-level message about that with the individual entries
    that are different than the default.
    
    Based on previous patch by Michal Wajdeczko.
    
    Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
    Cc: John Harrison <John.C.Harrison at Intel.com>
    Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch c3cf4289245819615518b536cd16ebe6612694f9 drm-intel
da9241f9da35 drm/xe/psmi: Add GuC flag to enable PSMI
a52d96accd7b drm/xe/psmi: Add debugfs interface for PSMI
-:111: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#111: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 373 lines checked
199d10e98df6 drm/xe/rtp: Add match for psmi
36b3e80fa866 drm/xe/psmi: Add Wa_14020001231
-:34: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#34: FILE: drivers/gpu/drm/xe/xe_guc_ads.c:364:
+				 GUC_WORKAROUND_KLV_DISABLE_PSMI_INTERRUPTS_AT_C6_ENTRY_RESTORE_AT_EXIT);

total: 0 errors, 1 warnings, 0 checks, 27 lines checked
65c980a147d9 drm/xe/psmi: Add Wa_16023683509
209855037caf drm/xe/configfs: Simplify kernel doc
c482811d90b1 drm/xe/configfs: Allow to enable PSMI
ffdb2ff05c91 drm/xe/configfs: Use guard() for dev->lock
0c8a81b8619d drm/xe/configfs: Block runtime attribute changes
ad48f73972da drm/xe/configfs: Use tree-like output in documentation
86234c489fb9 drm/xe/configfs: Improve documentation steps
a9c615ce10e0 drm/xe/configfs: Minor fixes to documentation
937127c1b585 drm/xe/configfs: Dump custom settings when binding
-:30: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'attr_' - possible side-effects?
#30: FILE: drivers/gpu/drm/xe/xe_configfs.c:489:
+#define PRI_CUSTOM_ATTR(fmt_, attr_) do { \
+		if (dev->config.attr_ != device_defaults.attr_) \
+			pci_info(pdev, "configfs: " __stringify(attr_) " = " fmt_ "\n", \
+				 dev->config.attr_); \
+	} while (0)

-:30: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'attr_' may be better as '(attr_)' to avoid precedence issues
#30: FILE: drivers/gpu/drm/xe/xe_configfs.c:489:
+#define PRI_CUSTOM_ATTR(fmt_, attr_) do { \
+		if (dev->config.attr_ != device_defaults.attr_) \
+			pci_info(pdev, "configfs: " __stringify(attr_) " = " fmt_ "\n", \
+				 dev->config.attr_); \
+	} while (0)

total: 0 errors, 0 warnings, 2 checks, 74 lines checked




More information about the Intel-xe mailing list