[PATCH] drm/i915/hdcp: Remove the encoder check in hdcp enable

Nautiyal, Ankit K ankit.k.nautiyal at intel.com
Wed Aug 20 08:41:56 UTC 2025


On 8/19/2025 8:37 PM, Suraj Kandpal wrote:
> Remove the intel_encoder NULL check from _intel_hdcp_enable

Missing period '.' here.


> with
> all the changes it has gone through this check has become unnecessary
> since at this point the connector is supposed to have the encoder
> in it.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>

With above typo fixed:

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>


> ---
>   drivers/gpu/drm/i915/display/intel_hdcp.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index 42202c8bb066..e11cf26ed0bf 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -2446,12 +2446,6 @@ static int _intel_hdcp_enable(struct intel_atomic_state *state,
>   	if (!hdcp->shim)
>   		return -ENOENT;
>   
> -	if (!connector->encoder) {
> -		drm_err(display->drm, "[CONNECTOR:%d:%s] encoder is not initialized\n",
> -			connector->base.base.id, connector->base.name);
> -		return -ENODEV;
> -	}
> -
>   	mutex_lock(&hdcp->mutex);
>   	mutex_lock(&dig_port->hdcp.mutex);
>   	drm_WARN_ON(display->drm,


More information about the Intel-xe mailing list