[PATCH] drm/xe: replace basename() with portable strrchr()

[Tiffany Yang]

"'Carlos Llamas' via kernel-team" <kernel-team at android.com> writes:

> Commit b0a2ee5567ab ("drm/xe: prepare xe_gen_wa_oob to be multi-use")
> introduced a call to basename(). The GNU version of this function is not
> portable and fails to build with alternative libc implementations like
> musl or bionic. This causes the following build error:

>    drivers/gpu/drm/xe/xe_gen_wa_oob.c:130:12: error: assignment to ‘const  
> char *’ from ‘int’ makes pointer from integer without a cast  
> [-Wint-conversion]
>      130 |         fn = basename(fn);
>          |            ^

> While a POSIX version of basename() could be used, it would require a
> separate header plus the behavior differs from GNU version in that it
> might modify its argument. Not great.

> Instead replace basename() with a strrchr() based implementation which
> provides the same functionality and avoid portability issues.

Nit: s/avoid/avoids. Other than that,


> Fixes: b0a2ee5567ab ("drm/xe: prepare xe_gen_wa_oob to be multi-use")
> Signed-off-by: Carlos Llamas <cmllamas at google.com>
> ---
>   drivers/gpu/drm/xe/xe_gen_wa_oob.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)


Reviewed-by: Tiffany Yang <ynaffit at google.com>

-- 
Tiffany Y. Yang