[PATCH 04/15] drm/xe: Pass down drm_exec context to validation

Thomas Hellström thomas.hellstrom at linux.intel.com
Fri Aug 22 07:40:28 UTC 2025


On Wed, 2025-08-13 at 09:42 -0700, Matthew Brost wrote:
> >   
> > +	/**
> > +	 * @validation: Validation data only valid with the vm
> > resv held.
> > +	 * Note: This is really task state of the task holding the
> > vm resv,
> > +	 * and moving forward we should
> > +	 * come up with a better way of passing this down the
> > call-
> > +	 * chain.
> 
> I've already mentioned this, attaching the _exec xe_vma_ops might be
> good option as xe_vma_ops has lifetime of only existing for the bind
> (i.e., it is stack variable) so you'd only need to set it (i.e., no
> clear required).

That is true, although since this is really task state the correct
thing would be to pass this as a parameter to the functions involved,
but when I tried to implement that, it got quite complicated.

So figuring saving this for a future cleanup might make sense. I'll do
that for v2 anyway, and we can discuss it further.

Thanks,
Thomas


> 
> I think patch largely makes sense.
> 
> Matt 
> 
> > +



More information about the Intel-xe mailing list