[PATCH v2] drm/xe: GPU frequency tracing support

Lucas De Marchi lucas.demarchi at intel.com
Fri Aug 22 19:30:19 UTC 2025


On Wed, Aug 20, 2025 at 04:25:43AM +0000, Sebinraj, S wrote:
>We went for this addition rather than the one in xe_pmu (via perf stat - user space tool),
>as we have a requirement to have the trace point available at d/evens/power/gpu_frequency for Android xTS.

sorry, but that's not a good justification. We should add code that
makes sense overall and can be used by *any* downstream. What am I going
to say when another downstream distro request the frequency to be
exported as xyz/events/power/gpu_frequency or with a different
signature or with a different sampling requirement.

The interface is not even generic enough to be useful elsewhere.

>In this case the user won't be triggering the perf subsystem for gpu frequency for gt0, gt1.. even if we add the trace points in xe_pmu.
>Other comments from Mathew have been addressed in the next revision https://patchwork.freedesktop.org/series/152701/#rev3

I don't think they really matter much. Until we figure out how to
fulfill the android requirement without poluting the codebase like you
are doing, we can't merge this. Sorry, but we can't maintain a
perf-subsystem-inside-xe for that.

Lucas De Marchi


More information about the Intel-xe mailing list