✗ CI.checkpatch: warning for drm/xe/pmu: Add GT frequency events (rev2)

[Patchwork]

== Series Details ==

Series: drm/xe/pmu: Add GT frequency events (rev2)
URL   : https://patchwork.freedesktop.org/series/144164/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 4fc896c0f9fd708413428fc44aba487e02146c81
Author: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
Date:   Tue Feb 4 10:09:05 2025 -0800

    drm/xe/pmu: Add GT frequency events
    
    Define PMU events for GT frequency (actual and requested). This is
    a port from the i915 driver implementation, where an internal timer
    is used to aggregate GT frequencies over certain fixed interval.
    Following PMU events are being added-
    
      xe_0000_00_02.0/gt-actual-frequency/              [Kernel PMU event]
      xe_0000_00_02.0/gt-requested-frequency/           [Kernel PMU event]
    
    Standard perf commands can be used to monitor GT frequency-
      $ perf stat -e xe_0000_00_02.0/gt-requested-frequency,gt=0/ -I1000
    
         1.001175175                700 M    xe/gt-requested-frequency,gt=0/
         2.005891881                703 M    xe/gt-requested-frequency,gt=0/
         3.007318169                700 M    xe/gt-requested-frequency,gt=0/
    
    Actual frequencies will be reported as 0 when GT is suspended.
    
    v2: Use locks while storing samples, keep track of multiple clients (Lucas)
    
    Cc: Riana Tauro <riana.tauro at intel.com>
    Cc: Lucas De Marchi <lucas.demarchi at intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
+ /mt/dim checkpatch ac87843456aa558a665df43aa62c03eaf7701bcb drm-intel
9707d54e4a47 drm/xe/pmu: Add event tracking
4fc896c0f9fd drm/xe/pmu: Add GT frequency events
-:110: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'event' may be better as '(event)' to avoid precedence issues
#110: FILE: drivers/gpu/drm/xe/xe_pmu.c:196:
+#define CONFIG_EVENT_ENABLED(config, event) \
+	(FIELD_GET(XE_PMU_EVENT_ID_MASK, config) & event)

-:113: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'config' - possible side-effects?
#113: FILE: drivers/gpu/drm/xe/xe_pmu.c:199:
+#define CONFIG_EVENT_ENABLED_GT(config, event, gt) \
+	(CONFIG_EVENT_ENABLED(config, event) && \
+	(FIELD_GET(XE_PMU_EVENT_GT_MASK, config) == gt))

-:113: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gt' may be better as '(gt)' to avoid precedence issues
#113: FILE: drivers/gpu/drm/xe/xe_pmu.c:199:
+#define CONFIG_EVENT_ENABLED_GT(config, event, gt) \
+	(CONFIG_EVENT_ENABLED(config, event) && \
+	(FIELD_GET(XE_PMU_EVENT_GT_MASK, config) == gt))

-:223: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#223: FILE: drivers/gpu/drm/xe/xe_pmu.c:433:
+XE_EVENT_ATTR_SIMPLE(gt-actual-frequency, gt_actual_frequency,
                        ^

-:223: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#223: FILE: drivers/gpu/drm/xe/xe_pmu.c:433:
+XE_EVENT_ATTR_SIMPLE(gt-actual-frequency, gt_actual_frequency,
                               ^

-:225: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#225: FILE: drivers/gpu/drm/xe/xe_pmu.c:435:
+XE_EVENT_ATTR_SIMPLE(gt-requested-frequency, gt_requested_frequency,
                        ^

-:225: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#225: FILE: drivers/gpu/drm/xe/xe_pmu.c:435:
+XE_EVENT_ATTR_SIMPLE(gt-requested-frequency, gt_requested_frequency,
                                  ^

total: 0 errors, 0 warnings, 7 checks, 247 lines checked