[PATCH v2] drm/xe/hwmon: expose package and vram temperature

[Andi Shyti]

On Wed, Feb 05, 2025 at 07:50:38PM +0200, Raag Jadav wrote:
> On Fri, Jan 31, 2025 at 02:35:27PM +0100, Andi Shyti wrote:
> > Hi Raag,
> > 
> > ...
> > 
> > > diff --git a/drivers/gpu/drm/xe/regs/xe_mchbar_regs.h b/drivers/gpu/drm/xe/regs/xe_mchbar_regs.h
> > > index 519dd1067a19..f5e5234857c1 100644
> > > --- a/drivers/gpu/drm/xe/regs/xe_mchbar_regs.h
> > > +++ b/drivers/gpu/drm/xe/regs/xe_mchbar_regs.h
> > > @@ -34,6 +34,9 @@
> > >  
> > >  #define PCU_CR_PACKAGE_ENERGY_STATUS		XE_REG(MCHBAR_MIRROR_BASE_SNB + 0x593c)
> > >  
> > > +#define PCU_CR_PACKAGE_TEMPERATURE		XE_REG(MCHBAR_MIRROR_BASE_SNB + 0x5978)
> > > +#define   TEMP_MASK				REG_GENMASK(7, 0)
> > 
> > is it called TEMP also in the docs? It can somehow be confused
> > with "temporary".
> 
> Doc just calls it DATA, but I went with GENMASK() macro convention here.
> And since it'll be used by temperature functions, the room for confusion is
> less likely.
> 
> > In any case:
> > 
> > Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>
> 
> I don't believe we allow duplicate tags (context: it's already in the patch),
> but at some point we might want to allow it for (re-)assurance :D
> 
> Thank you (x2).

ahaha... I was back from a sick leave and I missed it :-)

Andi