[PATCH v3 10/13] drm/xe: Move drm_dev_unplug() out of display function

[Upadhyay, Tejas]

> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Lucas
> De Marchi
> Sent: Saturday, February 8, 2025 3:50 AM
> To: intel-xe at lists.freedesktop.org
> Cc: Vivi, Rodrigo <rodrigo.vivi at intel.com>; Dugast, Francois
> <francois.dugast at intel.com>; Auld, Matthew <matthew.auld at intel.com>;
> Ceraolo Spurio, Daniele <daniele.ceraolospurio at intel.com>; De Marchi, Lucas
> <lucas.demarchi at intel.com>; Nikula, Jani <jani.nikula at intel.com>
> Subject: [PATCH v3 10/13] drm/xe: Move drm_dev_unplug() out of display
> function
> 
> This is not really display-related and needed for any sequence on driver
> removal that has to interact with drm_dev_enter()/drm_dev_exit().
> Just remove xe_device_remove_display() and inline it in the single caller to
> make clear this is not done only for display.
> 

I feel this is move is ok, LGTM,
Reviewed-by: Tejas Upadhyay <tejas.upadhyay at intel.com>

Tejas 
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_device.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 944a40a1e0174..5e4c50a70df35 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -954,20 +954,16 @@ void xe_device_add_remove_action(struct
> xe_device *xe,
>  	list_add(&ra->node, &xe->remove_action_list);  }
> 
> -static void xe_device_remove_display(struct xe_device *xe)
> +void xe_device_remove(struct xe_device *xe)
>  {
>  	xe_display_unregister(xe);
> 
>  	drm_dev_unplug(&xe->drm);
> +
>  	xe_display_driver_remove(xe);
> -}
> 
> -void xe_device_remove(struct xe_device *xe) -{
>  	xe_oa_unregister(xe);
> 
> -	xe_device_remove_display(xe);
> -
>  	xe_heci_gsc_fini(xe);
> 
>  	xe_device_call_remove_actions(xe);
> --
> 2.48.1