✗ CI.checkpatch: warning for drm_i915_private to intel_display cleanup

Patchwork patchwork at emeril.freedesktop.org
Mon Feb 10 12:53:14 UTC 2025


== Series Details ==

Series: drm_i915_private to intel_display cleanup
URL   : https://patchwork.freedesktop.org/series/144587/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
22f9cda3436b4fe965b5c5f31d2f2c1bcb483189
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 003d2984a59abe44ad8ca096dd9166d2165e665d
Author: Suraj Kandpal <suraj.kandpal at intel.com>
Date:   Mon Feb 10 18:09:50 2025 +0530

    drm/i915/dpll: Replace all other leftover drm_i915_private
    
    Replace all other left over drm_i915_private with intel_display
    in dpll_mgr.c.
    
    Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
+ /mt/dim checkpatch 71542b8e400e0d4ec7215e0b8b1fce67e5215f9f drm-intel
9f13969651c2 drm/i915/display_debug_fs: Use intel_display wherever possible
-:50: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 63)
#50: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:95:
+	if (DISPLAY_VER(display) >= 9)
 		/* no global SR status; inspect per-plane WM */;

total: 0 errors, 1 warnings, 0 checks, 506 lines checked
6b178adee435 drm/i915/display_debug_fs: Prefer using display->platform
23c0fe40df55 drm/i915/dpll: Change param to intel_display in for_each_shared_dpll
-:141: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects?
#141: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.h:33:
+#define for_each_shared_dpll(__display, __pll, __i) \
+	for ((__i) = 0; (__i) < (__display)->dpll.num_shared_dpll && \
+		     ((__pll) = &(__display)->dpll.shared_dplls[(__i)]) ; (__i)++)

-:141: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#141: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.h:33:
+#define for_each_shared_dpll(__display, __pll, __i) \
+	for ((__i) = 0; (__i) < (__display)->dpll.num_shared_dpll && \
+		     ((__pll) = &(__display)->dpll.shared_dplls[(__i)]) ; (__i)++)

total: 0 errors, 0 warnings, 2 checks, 218 lines checked
befd3ba4cc05 drm/i915/dpll: Use intel_display for dpll dump and compare hw state
ff10da9c3d55 drm/i915/dpll: Use intel_display possible in shared_dpll_mgr hooks
72e7fa648d19 drm/i915/dpll: Use intel_display for asserting pll
0ec63f912152 drm/i915/dpll: Use intel_display for update_refclk hook
d1e37fb0ae35 drm/i915/dpll: Accept intel_display as argument for shared_dpll_init
003d2984a59a drm/i915/dpll: Replace all other leftover drm_i915_private




More information about the Intel-xe mailing list