[PATCH v2 2/2] drm/xe: Add a WARN_ON for NULL job in xe_sync_entry_signal

[Upadhyay, Tejas]

Oops landed on wrong patch, please ignore.

> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of
> Upadhyay, Tejas
> Sent: Monday, February 10, 2025 11:36 PM
> To: Das, Nirmoy <nirmoy.das at intel.com>; intel-xe at lists.freedesktop.org
> Cc: Das, Nirmoy <nirmoy.das at intel.com>; Auld, Matthew
> <matthew.auld at intel.com>; Brost, Matthew <matthew.brost at intel.com>
> Subject: RE: [PATCH v2 2/2] drm/xe: Add a WARN_ON for NULL job in
> xe_sync_entry_signal
> 
> 
> 
> > -----Original Message-----
> > From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of
> > Nirmoy Das
> > Sent: Monday, March 18, 2024 10:14 PM
> > To: intel-xe at lists.freedesktop.org
> > Cc: Das, Nirmoy <nirmoy.das at intel.com>; Auld, Matthew
> > <matthew.auld at intel.com>; Brost, Matthew <matthew.brost at intel.com>
> > Subject: [PATCH v2 2/2] drm/xe: Add a WARN_ON for NULL job in
> > xe_sync_entry_signal
> >
> > Add a warn for NULL job when sync->type is
> > DRM_XE_SYNC_TYPE_USER_FENCE. This should be a programming error
> and
> > should never happen so warn and let the kernel crash if that ever happens.
> >
> > Cc: Matthew Auld <matthew.auld at intel.com>
> > Cc: Matthew Brost <matthew.brost at intel.com>
> > Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_sync.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_sync.c
> > b/drivers/gpu/drm/xe/xe_sync.c index 02c9577fe418..247505c3478d
> 100644
> > --- a/drivers/gpu/drm/xe/xe_sync.c
> > +++ b/drivers/gpu/drm/xe/xe_sync.c
> > @@ -255,6 +255,7 @@ void xe_sync_entry_signal(struct xe_sync_entry
> > *sync, struct xe_sched_job *job,
> >  			dma_fence_put(fence);
> >  		}
> >  	} else if (sync->type == DRM_XE_SYNC_TYPE_USER_FENCE) {
> > +		XE_WARN_ON(!job);
> 
> LGTM,
> Reviewed-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
> 
> >  		job->user_fence.used = true;
> >  		job->user_fence.addr = sync->addr;
> >  		job->user_fence.value = sync->timeline_value;
> > --
> > 2.42.0