[PATCH 2/2] drm/xe/guc_pc: Remove duplicated pc_start call

[Cavitt, Jonathan]

-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Rodrigo Vivi
Sent: Monday, February 10, 2025 1:07 PM
To: intel-xe at lists.freedesktop.org
Cc: Vivi, Rodrigo <rodrigo.vivi at intel.com>; Belgaumkar, Vinay <vinay.belgaumkar at intel.com>
Subject: [PATCH 2/2] drm/xe/guc_pc: Remove duplicated pc_start call
> 
> xe_guc_pc_start() was getting called from both
> xe_uc_init_hw() and from xe_guc_start().
> 
> But both are called from do_gt_restart() and only
> xe_uc_init_hw() is called at initialization.
> 
> So, let's remove the duplication in the regular gt_restart
> path.
> 
> The only place where xe_guc_pc_start() won't get called now
> is on the gt_reset failure path. However, if gt_reset has
> failed, it is really unlikely that the PC start will work
> or is desired.
> 
> Cc: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

Can verify.  A mirror of xe_guc_pc_start exists in xe_uc_hw_init.  And indirectly, both only
activate guc pc when SRIOV is not active.
LGTM.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/xe_guc.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
> index 1619c0a52db9..eaa035b25aa8 100644
> --- a/drivers/gpu/drm/xe/xe_guc.c
> +++ b/drivers/gpu/drm/xe/xe_guc.c
> @@ -1491,14 +1491,6 @@ void xe_guc_stop(struct xe_guc *guc)
>  
>  int xe_guc_start(struct xe_guc *guc)
>  {
> -	if (!IS_SRIOV_VF(guc_to_xe(guc))) {
> -		int err;
> -
> -		err = xe_guc_pc_start(&guc->pc);
> -		xe_gt_WARN(guc_to_gt(guc), err, "Failed to start GuC PC: %pe\n",
> -			   ERR_PTR(err));
> -	}
> -
>  	return xe_guc_submit_start(guc);
>  }
>  
> -- 
> 2.48.1
> 
>