✗ CI.checkpatch: warning for PMU support for engine activity (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Feb 11 10:49:11 UTC 2025


== Series Details ==

Series: PMU support for engine activity (rev2)
URL   : https://patchwork.freedesktop.org/series/144408/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
22f9cda3436b4fe965b5c5f31d2f2c1bcb483189
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit bc85c921545a2b5cf1b165c9fdcea27f7f9e7c6e
Author: Riana Tauro <riana.tauro at intel.com>
Date:   Tue Feb 11 15:39:50 2025 +0530

    drm/xe/pf: Enable per-function engine activity stats
    
    Enable per-function engine activity stats when VF's are enabled
    and disable when VF's are disabled
    
    v2: fix commit message
        remove reset stats from pf config (Michal)
    
    Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
    Signed-off-by: Riana Tauro <riana.tauro at intel.com>
+ /mt/dim checkpatch 27f9e4e3866556a4498e3b4ddebc27d4f6d0ae2f drm-intel
1ecc77b8d4b6 drm/xe: Add engine activity support
-:76: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#76: 
new file mode 100644

-:538: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#538: FILE: drivers/gpu/drm/xe/xe_guc_fwif.h:220:
+	struct guc_engine_activity engine_activity[GUC_MAX_ENGINE_CLASSES][GUC_MAX_INSTANCES_PER_CLASS];

total: 0 errors, 2 warnings, 0 checks, 491 lines checked
011eaf11fbda drm/xe/trace: Add trace for engine activity
-:66: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#66: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:109:
+	    TP_STRUCT__entry(

-:83: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#83: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:126:
+	    TP_fast_assign(

total: 0 errors, 0 warnings, 2 checks, 84 lines checked
e798a36469d2 drm/xe/guc: Expose engine activity only for supported GuC version
7dfd55cd965b drm/xe/xe_pmu: Add PMU support for engine activity
-:299: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#299: FILE: drivers/gpu/drm/xe/xe_pmu.c:373:
+XE_EVENT_ATTR_NOUNIT(engine-active-ticks, engine_active_ticks, XE_PMU_EVENT_ENGINE_ACTIVE_TICKS);
                            ^

-:299: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#299: FILE: drivers/gpu/drm/xe/xe_pmu.c:373:
+XE_EVENT_ATTR_NOUNIT(engine-active-ticks, engine_active_ticks, XE_PMU_EVENT_ENGINE_ACTIVE_TICKS);
                                   ^

-:300: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#300: FILE: drivers/gpu/drm/xe/xe_pmu.c:374:
+XE_EVENT_ATTR_NOUNIT(engine-total-ticks, engine_total_ticks, XE_PMU_EVENT_ENGINE_TOTAL_TICKS);
                            ^

-:300: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#300: FILE: drivers/gpu/drm/xe/xe_pmu.c:374:
+XE_EVENT_ATTR_NOUNIT(engine-total-ticks, engine_total_ticks, XE_PMU_EVENT_ENGINE_TOTAL_TICKS);
                                  ^

total: 0 errors, 0 warnings, 4 checks, 277 lines checked
44cf5249ce4e drm/xe/xe_pmu: Acquire forcewake on event init for engine events
bd3bb15d5290 drm/xe: Add support for per-function engine activity
66b16f519461 drm/xe/xe_pmu: Add PMU support for per-function engine activity stats
bc85c921545a drm/xe/pf: Enable per-function engine activity stats




More information about the Intel-xe mailing list