[PATCH 5/9] drm/i915/dpll: Use intel_display possible in shared_dpll_mgr hooks
Jani Nikula
jani.nikula at intel.com
Tue Feb 11 13:10:46 UTC 2025
On Tue, 11 Feb 2025, Suraj Kandpal <suraj.kandpal at intel.com> wrote:
> We use intel_display for function hooks of shared_dpll_mgr and
> any function that gets called when we use for_each_shared_dpll.
> This also contains some opportunistic display->platform.xx changes
> all to reductate the use of drm_i915_private.
>
> --v2
> -rebase
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
> ---
> /*
> * Try to set up the PCH reference clock once all DPLLs
> * that depend on it have been shut down.
> */
> - if (i915->display.dpll.pch_ssc_use & BIT(id))
> - intel_init_pch_refclk(i915);
> + if (display->dpll.pch_ssc_use & BIT(id))
> + intel_init_pch_refclk(to_i915(display->drm));
For future reference:
- Please don't add inline uses of to_i915().
- There's too much going on in one patch.
Regardless, this is supposed to be non-functional, so I'll let it pass.
Reviewed-by: Jani Nikula <jani.nikula at intel.com>
--
Jani Nikula, Intel
More information about the Intel-xe
mailing list