[PATCH v2] drm/xe/oa: Allow oa_exponent value of 0

[Dixit, Ashutosh]

On Wed, 12 Feb 2025 09:17:00 -0800, Dixit, Ashutosh wrote:
>
> On Wed, 12 Feb 2025 08:26:10 -0800, Umesh Nerlige Ramappa wrote:
> >
> > OA exponent value of 0 is a valid value for periodic reports. Allow user
> > to pass 0 for the OA sampling interval since it gets converted to 2 gt
> > clock ticks.
> >
> > v2: Update the check in xe_oa_stream_init as well (Ashutosh)
>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>

Sorry, maybe add a Fixes tag to this before you merge.

> >
> > Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_oa.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> > index a692dffcb638..9c95ad742f7d 100644
> > --- a/drivers/gpu/drm/xe/xe_oa.c
> > +++ b/drivers/gpu/drm/xe/xe_oa.c
> > @@ -1690,7 +1690,7 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream,
> >	stream->oa_buffer.format = &stream->oa->oa_formats[param->oa_format];
> >
> >	stream->sample = param->sample;
> > -	stream->periodic = param->period_exponent > 0;
> > +	stream->periodic = param->period_exponent >= 0;
> >	stream->period_exponent = param->period_exponent;
> >	stream->no_preempt = param->no_preempt;
> >	stream->wait_num_reports = param->wait_num_reports;
> > @@ -2025,7 +2025,7 @@ int xe_oa_stream_open_ioctl(struct drm_device *dev, u64 data, struct drm_file *f
> >		goto err_exec_q;
> >	}
> >
> > -	if (param.period_exponent > 0) {
> > +	if (param.period_exponent >= 0) {
> >		u64 oa_period, oa_freq_hz;
> >
> >		/* Requesting samples from OAG buffer is a privileged operation */
> > --
> > 2.34.1
> >