✗ CI.checkpatch: warning for PMU support for engine activity (rev3)
Patchwork
patchwork at emeril.freedesktop.org
Fri Feb 14 09:55:04 UTC 2025
== Series Details ==
Series: PMU support for engine activity (rev3)
URL : https://patchwork.freedesktop.org/series/144408/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
22f9cda3436b4fe965b5c5f31d2f2c1bcb483189
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f24fce30d917dc328f6e7ec80d6c80f18cfd1b6e
Author: Riana Tauro <riana.tauro at intel.com>
Date: Fri Feb 14 15:38:13 2025 +0530
drm/xe/xe_pmu: Acquire forcewake on event init for engine events
When the engine events are created, acquire GT forcewake to read gpm
timestamp required for the events and release on event destroy. This
cannot be done during read due to the raw spinlock held my pmu.
v2: remove forcewake counting (Umesh)
v3: remove extra space (Umesh)
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
Signed-off-by: Riana Tauro <riana.tauro at intel.com>
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
+ /mt/dim checkpatch 57457d93f156d8b4bdff8d138127d81b8f97d8c9 drm-intel
fc5a1a4179f0 drm/xe: Add engine activity support
-:76: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#76:
new file mode 100644
-:538: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#538: FILE: drivers/gpu/drm/xe/xe_guc_fwif.h:220:
+ struct guc_engine_activity engine_activity[GUC_MAX_ENGINE_CLASSES][GUC_MAX_INSTANCES_PER_CLASS];
total: 0 errors, 2 warnings, 0 checks, 491 lines checked
25664c5a4d8f drm/xe/trace: Add trace for engine activity
-:66: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#66: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:109:
+ TP_STRUCT__entry(
-:83: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#83: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:126:
+ TP_fast_assign(
total: 0 errors, 0 warnings, 2 checks, 84 lines checked
e1a71684cfd1 drm/xe/guc: Expose engine activity only for supported GuC version
120237933264 drm/xe/xe_pmu: Add PMU support for engine activity
-:299: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#299: FILE: drivers/gpu/drm/xe/xe_pmu.c:373:
+XE_EVENT_ATTR_NOUNIT(engine-active-ticks, engine_active_ticks, XE_PMU_EVENT_ENGINE_ACTIVE_TICKS);
^
-:299: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#299: FILE: drivers/gpu/drm/xe/xe_pmu.c:373:
+XE_EVENT_ATTR_NOUNIT(engine-active-ticks, engine_active_ticks, XE_PMU_EVENT_ENGINE_ACTIVE_TICKS);
^
-:300: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#300: FILE: drivers/gpu/drm/xe/xe_pmu.c:374:
+XE_EVENT_ATTR_NOUNIT(engine-total-ticks, engine_total_ticks, XE_PMU_EVENT_ENGINE_TOTAL_TICKS);
^
-:300: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#300: FILE: drivers/gpu/drm/xe/xe_pmu.c:374:
+XE_EVENT_ATTR_NOUNIT(engine-total-ticks, engine_total_ticks, XE_PMU_EVENT_ENGINE_TOTAL_TICKS);
^
total: 0 errors, 0 warnings, 4 checks, 277 lines checked
f24fce30d917 drm/xe/xe_pmu: Acquire forcewake on event init for engine events
More information about the Intel-xe
mailing list