[PATCH] drm/xe: Add fault injection for xe_sync_entry_parse

K V P, Satyanarayana satyanarayana.k.v.p at intel.com
Fri Feb 14 10:16:28 UTC 2025


Hi
> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of
> priyanka.dandamudi at intel.com
> Sent: Wednesday, February 12, 2025 3:02 PM
> To: Dandamudi, Priyanka <priyanka.dandamudi at intel.com>; Dugast, Francois
> <francois.dugast at intel.com>; intel-xe at lists.freedesktop.org
> Subject: [PATCH] drm/xe: Add fault injection for xe_sync_entry_parse
> 
> From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> 
> Add fault injection for xe_sync_entry_parse to allow it to fail while
> executing xe_vm_bind_ioctl().
> This need to be added as it cannot be reached by injecting error through
> IOCTL arguments.
> 
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_sync.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_sync.c b/drivers/gpu/drm/xe/xe_sync.c
> index 42f5bebd09e5..f87276df18f2 100644
> --- a/drivers/gpu/drm/xe/xe_sync.c
> +++ b/drivers/gpu/drm/xe/xe_sync.c
> @@ -210,6 +210,7 @@ int xe_sync_entry_parse(struct xe_device *xe, struct
> xe_file *xef,
> 
>  	return 0;
>  }
> +ALLOW_ERROR_INJECTION(xe_sync_entry_parse, ERRNO);
> 
This change LGTM, but it is better to have an IGT test which can cover this fail_function.
-Satya.
>  int xe_sync_entry_add_deps(struct xe_sync_entry *sync, struct xe_sched_job
> *job)
>  {
> --
> 2.34.1



More information about the Intel-xe mailing list