[PATCH] drm/xe: Add fault injection for xe_sync_entry_parse

[K V P, Satyanarayana]

Hi.
> -----Original Message-----
> From: Dandamudi, Priyanka <priyanka.dandamudi at intel.com>
> Sent: Saturday, February 15, 2025 10:37 AM
> To: K V P, Satyanarayana <satyanarayana.k.v.p at intel.com>; Dugast, Francois
> <francois.dugast at intel.com>; intel-xe at lists.freedesktop.org
> Subject: RE: [PATCH] drm/xe: Add fault injection for xe_sync_entry_parse
> 
> 
> 
> > -----Original Message-----
> > From: K V P, Satyanarayana <satyanarayana.k.v.p at intel.com>
> > Sent: 14 February 2025 03:46 PM
> > To: Dandamudi, Priyanka <priyanka.dandamudi at intel.com>; Dandamudi,
> > Priyanka <priyanka.dandamudi at intel.com>; Dugast, Francois
> > <francois.dugast at intel.com>; intel-xe at lists.freedesktop.org
> > Cc: K V P, Satyanarayana <satyanarayana.k.v.p at intel.com>
> > Subject: RE: [PATCH] drm/xe: Add fault injection for xe_sync_entry_parse
> >
> > Hi
> > > -----Original Message-----
> > > From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of
> > > priyanka.dandamudi at intel.com
> > > Sent: Wednesday, February 12, 2025 3:02 PM
> > > To: Dandamudi, Priyanka <priyanka.dandamudi at intel.com>; Dugast,
> > > Francois <francois.dugast at intel.com>; intel-xe at lists.freedesktop.org
> > > Subject: [PATCH] drm/xe: Add fault injection for xe_sync_entry_parse
> > >
> > > From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> > >
> > > Add fault injection for xe_sync_entry_parse to allow it to fail while
> > > executing xe_vm_bind_ioctl().
> > > This need to be added as it cannot be reached by injecting error
> > > through IOCTL arguments.
> > >
> > > Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> > > ---
> > >  drivers/gpu/drm/xe/xe_sync.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/xe/xe_sync.c
> > > b/drivers/gpu/drm/xe/xe_sync.c index 42f5bebd09e5..f87276df18f2
> 100644
> > > --- a/drivers/gpu/drm/xe/xe_sync.c
> > > +++ b/drivers/gpu/drm/xe/xe_sync.c
> > > @@ -210,6 +210,7 @@ int xe_sync_entry_parse(struct xe_device *xe,
> > > struct xe_file *xef,
> > >
> > >  	return 0;
> > >  }
> > > +ALLOW_ERROR_INJECTION(xe_sync_entry_parse, ERRNO);
> > >
> > fail_function.
> > -Satya.
> I already sent IGT test to validate this change.
> https://patchwork.freedesktop.org/series/144708/
> --Priyanka
LGTM.
Please include IGT patch details in the covering letter. More details can be found at https://intel-gfx-ci.01.org/test-with.html
Reviewed-by: Satyanarayana K V P <satyanarayana.k.v.p at intel.com>
> > >  int xe_sync_entry_add_deps(struct xe_sync_entry *sync, struct
> > > xe_sched_job
> > > *job)
> > >  {
> > > --
> > > 2.34.1