✗ CI.checkpatch: warning for drm/i915/fbc: FBC Dirty rect feature support (rev2)

Patchwork patchwork at emeril.freedesktop.org
Sun Feb 16 20:15:58 UTC 2025


== Series Details ==

Series: drm/i915/fbc: FBC Dirty rect feature support (rev2)
URL   : https://patchwork.freedesktop.org/series/144723/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
22f9cda3436b4fe965b5c5f31d2f2c1bcb483189
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit d7680dd231782c484d621e95f7ec77c99db6a082
Author: Vinod Govindapillai <vinod.govindapillai at intel.com>
Date:   Sun Feb 16 22:09:06 2025 +0200

    drm/i915/fbc: handle dirty rect coords for the first frame
    
    During enablig FBC, for the very first frame, the prepare dirty
    rect routine wouldnt have executed as at that time the plane
    reference in the fbc_state would be NULL. So this could make
    driver program some invalid entries as the damage area. Though
    fbc hw ignores the dirty rect values programmed for the first
    frame after enabling FBC, driver must ensure that valid dirty
    rect coords are programmed. So ensure that for the first frame
    prepare dirty rect is called at the time enabling FBC.
    
    Signed-off-by: Vinod Govindapillai <vinod.govindapillai at intel.com>
+ /mt/dim checkpatch 27f464a14e8d7d6c1e86e821a1f5ece6c0540e18 drm-intel
77f2a28b7534 drm/damage-helper: add const qualifier in drm_atomic_helper_damage_merged()
f7aff0382dcf drm/i915/display: update and store the plane damage clips
59e7ff50b56f drm/i915/fbc: add register definitions for fbc dirty rect support
-:26: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#26: FILE: drivers/gpu/drm/i915/display/intel_fbc_regs.h:107:
+#define   FBC_DIRTY_RECT_START_LINE(val)	REG_FIELD_PREP(FBC_DIRTY_RECT_START_LINE_MASK, (val))

total: 0 errors, 1 warnings, 0 checks, 15 lines checked
a976969bd239 drm/i915/fbc: introduce HAS_FBC_DIRTY_RECT() for FBC dirty rect support
86f67e8427dd drm/i915/fbc: avoid calling fbc activate if fbc is active
c0f672d7d8b8 drm/i915/fbc: dirty rect support for FBC
d3c3ee543966 drm/i915/fbc: disable FBC if PSR2 selective fetch is enabled
d7680dd23178 drm/i915/fbc: handle dirty rect coords for the first frame




More information about the Intel-xe mailing list