[PATCH 9/9] drm/xe: Stop ignoring errors from xe_ttm_sys_mgr_init()

Upadhyay, Tejas tejas.upadhyay at intel.com
Mon Feb 17 12:43:01 UTC 2025



> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Lucas
> De Marchi
> Sent: Saturday, February 15, 2025 2:53 AM
> To: intel-xe at lists.freedesktop.org
> Cc: De Marchi, Lucas <lucas.demarchi at intel.com>
> Subject: [PATCH 9/9] drm/xe: Stop ignoring errors from xe_ttm_sys_mgr_init()
> 
> xe_ttm_sys_mgr_init() already cleans up after itself, just return error if that
> failed.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_device.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 3255c36700f60..8b13b22b62bd6 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -748,6 +748,7 @@ int xe_device_probe(struct xe_device *xe)
>  		return err;
> 
>  	xe->info.mem_region_mask = 1;
> +
>  	err = xe_set_dma_info(xe);
>  	if (err)
>  		return err;
> @@ -756,7 +757,9 @@ int xe_device_probe(struct xe_device *xe)
>  	if (err)
>  		return err;
> 
> -	xe_ttm_sys_mgr_init(xe);
> +	err = xe_ttm_sys_mgr_init(xe);
> +	if (err)
> +		return err;

LGTM,
Reviewed-by: Tejas Upadhyay <tejas.upadhyay at intel.com>

> 
>  	for_each_gt(gt, xe, id) {
>  		err = xe_gt_init_early(gt);
> --
> 2.48.1



More information about the Intel-xe mailing list