[PATCH] drm/xe: Drop unnecessary GT lookup in xe_exec_queue_create_ioctl()

[Cavitt, Jonathan]

-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Matt Roper
Sent: Tuesday, February 18, 2025 12:05 PM
To: intel-xe at lists.freedesktop.org
Cc: Roper, Matthew D <matthew.d.roper at intel.com>
Subject: [PATCH] drm/xe: Drop unnecessary GT lookup in xe_exec_queue_create_ioctl()
> 
> xe_exec_queue_create_ioctl() performs a lookup of the xe_gt for the GT
> ID passed from userspace, but the result is never actually used.  Since
> there's already a separate (and earlier) check that the ID passed from
> userspace is valid, the unnecessary lookup can be removed.
> 
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>

Verified.  calc_validate_logical_mask() uses eci.gt_id, but not struct xe_gt *gt.
And *gt is otherwise unused in xe_exec_queue_create_ioctl().

Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/xe_exec_queue.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
> index 6051db78d706..23a9f519ce1c 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue.c
> +++ b/drivers/gpu/drm/xe/xe_exec_queue.c
> @@ -539,7 +539,7 @@ static int exec_queue_user_extensions(struct xe_device *xe, struct xe_exec_queue
>  	return 0;
>  }
>  
> -static u32 calc_validate_logical_mask(struct xe_device *xe, struct xe_gt *gt,
> +static u32 calc_validate_logical_mask(struct xe_device *xe,
>  				      struct drm_xe_engine_class_instance *eci,
>  				      u16 width, u16 num_placements)
>  {
> @@ -601,7 +601,6 @@ int xe_exec_queue_create_ioctl(struct drm_device *dev, void *data,
>  		u64_to_user_ptr(args->instances);
>  	struct xe_hw_engine *hwe;
>  	struct xe_vm *vm;
> -	struct xe_gt *gt;
>  	struct xe_tile *tile;
>  	struct xe_exec_queue *q = NULL;
>  	u32 logical_mask;
> @@ -654,8 +653,7 @@ int xe_exec_queue_create_ioctl(struct drm_device *dev, void *data,
>  					      &q->multi_gt_link);
>  		}
>  	} else {
> -		gt = xe_device_get_gt(xe, eci[0].gt_id);
> -		logical_mask = calc_validate_logical_mask(xe, gt, eci,
> +		logical_mask = calc_validate_logical_mask(xe, eci,
>  							  args->width,
>  							  args->num_placements);
>  		if (XE_IOCTL_DBG(xe, !logical_mask))
> -- 
> 2.48.1
> 
>