✗ CI.checkpatch: warning for drm/xe/xe_drm_client: Add per drm client reset stats (rev2)

[Patchwork]

== Series Details ==

Series: drm/xe/xe_drm_client: Add per drm client reset stats (rev2)
URL   : https://patchwork.freedesktop.org/series/144903/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
22f9cda3436b4fe965b5c5f31d2f2c1bcb483189
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 19799f486af089f211a3140dc31aa389feae65e3
Author: Jonathan Cavitt <jonathan.cavitt at intel.com>
Date:   Tue Feb 18 20:24:26 2025 +0000

    drm/xe/xe_query: Add support for per-drm-client reset stat querying
    
    Add support for userspace to query per drm client reset stats via the
    query ioctl.  This includes the number of engine resets the drm client
    has observed, as well as a list of up to the last 50 relevant exec
    queue bans and their associated causal pagefaults (if they exists).
    
    Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
+ /mt/dim checkpatch 5b90e253264600ca6750777faee5e96061ce6d8e drm-intel
ccb22cad68cf drm/xe/xe_exec_queue: Add ID param to exec queue struct
24c0cd6fdaae drm/xe/xe_gt_pagefault: Migrate pagefault struct to header
feadae2d5d12 drm/xe/xe_drm_client: Add per drm client pagefault info
-:63: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*b)...) over kzalloc(sizeof(struct blame)...)
#63: FILE: drivers/gpu/drm/xe/xe_drm_client.c:185:
+	b = kzalloc(sizeof(struct blame), GFP_KERNEL);

-:74: WARNING:LINE_SPACING: Missing a blank line after declarations
#74: FILE: drivers/gpu/drm/xe/xe_drm_client.c:196:
+		struct blame *rem = list_first_entry(&client->blame_list, struct blame, list);
+		free_blame(rem);

-:86: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*pf)...) over kzalloc(sizeof(struct pagefault)...)
#86: FILE: drivers/gpu/drm/xe/xe_drm_client.c:208:
+		pf = kzalloc(sizeof(struct pagefault), GFP_KERNEL);

-:109: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#109: FILE: drivers/gpu/drm/xe/xe_drm_client.c:231:
+
+}

-:232: WARNING:NEEDLESS_IF: kfree(NULL) is safe and this check is probably not required
#232: FILE: drivers/gpu/drm/xe/xe_gt_pagefault.c:342:
+		if (hwe->pf.info)
+			kfree(hwe->pf.info);

-:233: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*hwe->pf.info)...) over kzalloc(sizeof(struct pagefault)...)
#233: FILE: drivers/gpu/drm/xe/xe_gt_pagefault.c:343:
+		hwe->pf.info = kzalloc(sizeof(struct pagefault), GFP_KERNEL);

-:303: WARNING:NEEDLESS_IF: kfree(NULL) is safe and this check is probably not required
#303: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:2003:
+	if (hwe->pf.info) {
+		kfree(hwe->pf.info);

-:304: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*hwe->pf.info)...) over kzalloc(sizeof(struct pagefault)...)
#304: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:2004:
+		hwe->pf.info = kzalloc(sizeof(struct pagefault), GFP_KERNEL);

total: 0 errors, 3 warnings, 5 checks, 289 lines checked
b3f161fdb106 drm/xe/xe_drm_client: Add per drm client reset stats
d98ae4bca336 drm/xe/xe_query: Pass drm file to query funcs
19799f486af0 drm/xe/xe_query: Add support for per-drm-client reset stat querying