✗ CI.checkpatch: warning for drm/xe/pxp: Don't kill queues while holding PXP locks

Patchwork patchwork at emeril.freedesktop.org
Thu Feb 20 00:01:00 UTC 2025


== Series Details ==

Series: drm/xe/pxp: Don't kill queues while holding PXP locks
URL   : https://patchwork.freedesktop.org/series/145134/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
22f9cda3436b4fe965b5c5f31d2f2c1bcb483189
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit e871d50a629dd2e1536e0cfb331ea79a46627dde
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Date:   Wed Feb 19 15:52:36 2025 -0800

    drm/xe/pxp: Don't kill queues while holding PXP locks
    
    xe_exec_queue_kill can sleep, so we can't call it from under a spinlock.
    We can instead move the queues to a separate list and then kill them all
    after we release the spinlock.
    
    Furthermore, xe_exec_queue_kill can take the VM lock so we can't call it
    while holding the PXP mutex because the mutex is taken under VM lock at
    queue creation time. Note that while it is safe to call the kill without
    holding the mutex, we must call it after the PXP state has been updated,
    otherwise an app might be able to create a queue between the
    invalidation and the state update, which would break the state machine.
    
    Since being in the list is used to track whether RPM cleanup is needed,
    we can no longer defer that to queue_destroy, so we perform it
    immediately instead.
    
    v2: also avoid calling kill() under pxp->mutex.
    
    Reported-by: Dan Carpenter <dan.carpenter at linaro.org>
    Fixes: f8caa80154c4 ("drm/xe/pxp: Add PXP queue tracking and session start")
    Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
    Cc: John Harrison <John.C.Harrison at Intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch e19eb43c82480789a93ce0c452e22bbd851b93c6 drm-intel
e871d50a629d drm/xe/pxp: Don't kill queues while holding PXP locks
-:23: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#23: 
Reported-by: Dan Carpenter <dan.carpenter at linaro.org>
Fixes: f8caa80154c4 ("drm/xe/pxp: Add PXP queue tracking and session start")

total: 0 errors, 1 warnings, 0 checks, 149 lines checked




More information about the Intel-xe mailing list