[PATCH v3 1/2] drm/xe/devcoredump: Fix print typo of offset

[Upadhyay, Tejas]

> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of
> Shuicheng Lin
> Sent: Thursday, February 20, 2025 5:47 AM
> To: intel-xe at lists.freedesktop.org
> Cc: Lin, Shuicheng <shuicheng.lin at intel.com>; Harrison, John C
> <john.c.harrison at intel.com>; De Marchi, Lucas <lucas.demarchi at intel.com>
> Subject: [PATCH v3 1/2] drm/xe/devcoredump: Fix print typo of offset
> 
> The log should print with "offset" instead of "size".
> Correct the typo in the comment.
> 
> v2: split kzalloc change and add typo fix in commit message (Lucas)
> 
> Signed-off-by: Shuicheng Lin <shuicheng.lin at intel.com>
> Cc: John Harrison <John.C.Harrison at Intel.com>
> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_devcoredump.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c
> b/drivers/gpu/drm/xe/xe_devcoredump.c
> index 39fe485d2085..60d15e455017 100644
> --- a/drivers/gpu/drm/xe/xe_devcoredump.c
> +++ b/drivers/gpu/drm/xe/xe_devcoredump.c
> @@ -237,7 +237,7 @@ static void
> xe_devcoredump_deferred_snap_work(struct work_struct *work)
> 
>  	/*
>  	 * NB: Despite passing a GFP_ flags parameter here, more allocations
> are done
> -	 * internally using GFP_KERNEL expliictly. Hence this call must be in the
> worker
> +	 * internally using GFP_KERNEL explicitly. Hence this call must be in
> +the worker

This change looks unintentional?

>  	 * thread and not in the initial capture call.
>  	 */
>  	dev_coredumpm_timeout(gt_to_xe(ss->gt)->drm.dev,
> THIS_MODULE, coredump, 0, GFP_KERNEL, @@ -423,7 +423,7 @@ void
> xe_print_blob_ascii85(struct drm_printer *p, const char *prefix, char suffi
>  	if (size & 3)
>  		drm_printf(p, "Size not word aligned: %zu", size);
>  	if (offset & 3)
> -		drm_printf(p, "Offset not word aligned: %zu", size);
> +		drm_printf(p, "Offset not word aligned: %zu", offset);

LGTM,
Reviewed-by: Tejas Upadhyay <tejas.upadhyay at intel.com>

Tejas
> 
>  	line_buff = kzalloc(DMESG_MAX_LINE_LEN, GFP_KERNEL);
>  	if (IS_ERR_OR_NULL(line_buff)) {
> --
> 2.25.1