✗ CI.checkpatch: warning for drm/xe/guc: Track FAST_REQ H2Gs to report where errors came from

[Patchwork]

== Series Details ==

Series: drm/xe/guc: Track FAST_REQ H2Gs to report where errors came from
URL   : https://patchwork.freedesktop.org/series/145205/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
22f9cda3436b4fe965b5c5f31d2f2c1bcb483189
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 75c93c63ac1a37a6e943611fba0f2fbdf224c9cc
Author: John Harrison <John.C.Harrison at Intel.com>
Date:   Thu Feb 20 19:14:44 2025 -0800

    drm/xe/guc: Track FAST_REQ H2Gs to report where errors came from
    
    Most H2G messages are FAST_REQ which means no synchronous response is
    expected. The messages are sent as fire-and-forget with no tracking.
    However, errors can still be returned when something goes unexpectedly
    wrong. That leads to confusion due to not being able to match up the
    error response to the originating H2G.
    
    So add support for tracking the FAST_REQ H2Gs and matching up an error
    response to its originator. This is only enabled in XE_DEBUG builds
    given that such errors should never happen in a working system and
    there is an overhead for the tracking.
    
    Further, if XE_DEBUG_GUC is enabled then even more memory and time is
    used to record the call stack of each H2G and report that with an
    error. That makes it much easier to work out where a specific H2G came
    from if there are multiple code paths that can send it.
    
    Note, rather than create an extra Kconfig define for just this
    feature, the XE_LARGE_GUC_BUFFER option has been re-used and renamed
    to XE_DEBUG_GUC and is now just a general purpose 'verbose GuC debug'
    option.
    
    Lastly, add a define to document FAST_REQ error 0x30C as being the
    error most recently hit. Not sure why it was previously missing.
    
    Original-i915-code: Michal Wajdeczko <michal.wajdeczko at intel.com>
    Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
+ /mt/dim checkpatch 773b5639a9ff0a33feccb29de7f2d852c6d7f221 drm-intel
75c93c63ac1a drm/xe/guc: Track FAST_REQ H2Gs to report where errors came from
-:44: WARNING:CONFIG_DESCRIPTION: please write a help paragraph that fully describes the config symbol
#44: FILE: drivers/gpu/drm/xe/Kconfig.debug:89:
+config DRM_XE_DEBUG_GUC
+        bool "Enable extra GuC related debug options"
+        depends on DRM_XE_DEBUG
         default n
+        select STACKDEPOT
         help
           Choose this option when debugging guc issues.
+          The GuC log buffer is increased to the maximum allowed, which should
+          The GuC log buffer is increased to the maximum allowed, which should
+          be large enough for complex issues. It also enables recording of the
+          stack when tracking FAST_REQ messages.
 
           Recommended for driver developers only.
 

total: 0 errors, 1 warnings, 0 checks, 203 lines checked