[PATCH 3/9] drm/xe: Switch from xe to devm actions
Lucas De Marchi
lucas.demarchi at intel.com
Fri Feb 21 22:44:18 UTC 2025
On Fri, Feb 14, 2025 at 10:18:35PM +0000, Cavitt, Jonathan wrote:
>-----Original Message-----
>From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Lucas De Marchi
>Sent: Friday, February 14, 2025 1:23 PM
>To: intel-xe at lists.freedesktop.org
>Cc: De Marchi, Lucas <lucas.demarchi at intel.com>
>Subject: [PATCH 3/9] drm/xe: Switch from xe to devm actions
>>
>> Now that component drivers are compatible with devm, switch to using it
>> instead of our own.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>
>Looks good to me, though since we removed all calls to
>xe_device_add_action_or_reset in this patch, we may want
>to consider removing the declaration here (I.E. take the
>removal from patch 4 and do it here). Alternatively, we
>should probably just squash this with patch 4 in this series.
but then it's mixing the impl removal with the removal of its users...
I'd prefer to keep it like this.
>
>But besides that:
>Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
thanks
Lucas De Marchi
More information about the Intel-xe
mailing list