✗ CI.checkpatch: warning for drm/xe/uc: Add support for different firmware files on each GT

[Patchwork]

== Series Details ==

Series: drm/xe/uc: Add support for different firmware files on each GT
URL   : https://patchwork.freedesktop.org/series/145355/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
22f9cda3436b4fe965b5c5f31d2f2c1bcb483189
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 2f6e0df531e50b458f2c128c277330cdb044597b
Author: John Harrison <John.C.Harrison at Intel.com>
Date:   Mon Feb 24 14:21:24 2025 -0800

    drm/xe/uc: Add support for different firmware files on each GT
    
    The different GTs on a device can be very different. So add support
    for being able to load a different GuC firmware image that is tailored
    to the specific GT type.
    
    Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
    Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
+ /mt/dim checkpatch 9f112b86fd27ff7de2ce09718596cfefd71ee41f drm-intel
2f6e0df531e5 drm/xe/uc: Add support for different firmware files on each GT
-:76: WARNING:MACRO_ARG_UNUSED: Argument 'b' is not used in function-like macro
#76: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:145:
+#define fw_filename_major_ver(dir_, uc_, shortname_, a, b, c, t)		\
+	MAKE_FW_PATH(dir_, uc_, shortname_, t, "_" __stringify(a))

-:76: WARNING:MACRO_ARG_UNUSED: Argument 'c' is not used in function-like macro
#76: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:145:
+#define fw_filename_major_ver(dir_, uc_, shortname_, a, b, c, t)		\
+	MAKE_FW_PATH(dir_, uc_, shortname_, t, "_" __stringify(a))

-:92: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#92: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:152:
+#define uc_fw_entry_mmp_ver(dir_, uc_, shortname_, a, b, c, t)			\
+	{ fw_filename_mmp_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, true, t }

-:92: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#92: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:152:
+#define uc_fw_entry_mmp_ver(dir_, uc_, shortname_, a, b, c, t)			\
+	{ fw_filename_mmp_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, true, t }

-:92: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'c' - possible side-effects?
#92: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:152:
+#define uc_fw_entry_mmp_ver(dir_, uc_, shortname_, a, b, c, t)			\
+	{ fw_filename_mmp_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, true, t }

-:92: CHECK:MACRO_ARG_REUSE: Macro argument reuse 't' - possible side-effects?
#92: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:152:
+#define uc_fw_entry_mmp_ver(dir_, uc_, shortname_, a, b, c, t)			\
+	{ fw_filename_mmp_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, true, t }

-:95: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#95: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:155:
+#define uc_fw_entry_major_ver(dir_, uc_, shortname_, a, b, c, t)		\
+	{ fw_filename_major_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, false, t }

-:95: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#95: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:155:
+#define uc_fw_entry_major_ver(dir_, uc_, shortname_, a, b, c, t)		\
+	{ fw_filename_major_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, false, t }

-:95: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'c' - possible side-effects?
#95: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:155:
+#define uc_fw_entry_major_ver(dir_, uc_, shortname_, a, b, c, t)		\
+	{ fw_filename_major_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, false, t }

-:95: CHECK:MACRO_ARG_REUSE: Macro argument reuse 't' - possible side-effects?
#95: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:155:
+#define uc_fw_entry_major_ver(dir_, uc_, shortname_, a, b, c, t)		\
+	{ fw_filename_major_ver(dir_, uc_, shortname_, a, b, c, t),		\
+	  a, b, c, false, t }

total: 0 errors, 2 warnings, 8 checks, 114 lines checked