✗ CI.checkpatch: warning for drm/xe: SVM squash for CI (rev3)
Patchwork
patchwork at emeril.freedesktop.org
Thu Feb 27 08:49:29 UTC 2025
== Series Details ==
Series: drm/xe: SVM squash for CI (rev3)
URL : https://patchwork.freedesktop.org/series/145551/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
22f9cda3436b4fe965b5c5f31d2f2c1bcb483189
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit a05236b3c48eeab257d4d9893652a3c89c047112
Author: Matthew Brost <matthew.brost at intel.com>
Date: Thu Feb 27 00:43:29 2025 -0800
drm/xe: SVM squash for CI
Fixing Kconfig issues, kernel doc, sending for CI. Do not review.
Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 748d23cc64f7db34dbf1ab7b97e48824a3cb596f drm-intel
a05236b3c48e drm/xe: SVM squash for CI
-:11: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#11:
new file mode 100644
-:16: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#16: FILE: Documentation/gpu/rfc/gpusvm.rst:1:
+===============
-:346: WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns
#346: FILE: drivers/gpu/drm/drm_gpusvm.c:194:
+ * if (err == -EOPNOTSUPP || err == -EFAULT || err == -EPERM) { // CPU mappings changed
-:553: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'range__' - possible side-effects?
#553: FILE: drivers/gpu/drm/drm_gpusvm.c:401:
+#define drm_gpusvm_for_each_range_safe(range__, next__, notifier__, start__, end__) \
+ for ((range__) = drm_gpusvm_range_find((notifier__), (start__), (end__)), \
+ (next__) = __drm_gpusvm_range_next(range__); \
+ (range__) && (drm_gpusvm_range_start(range__) < (end__)); \
+ (range__) = (next__), (next__) = __drm_gpusvm_range_next(range__))
-:553: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'next__' - possible side-effects?
#553: FILE: drivers/gpu/drm/drm_gpusvm.c:401:
+#define drm_gpusvm_for_each_range_safe(range__, next__, notifier__, start__, end__) \
+ for ((range__) = drm_gpusvm_range_find((notifier__), (start__), (end__)), \
+ (next__) = __drm_gpusvm_range_next(range__); \
+ (range__) && (drm_gpusvm_range_start(range__) < (end__)); \
+ (range__) = (next__), (next__) = __drm_gpusvm_range_next(range__))
-:553: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'end__' - possible side-effects?
#553: FILE: drivers/gpu/drm/drm_gpusvm.c:401:
+#define drm_gpusvm_for_each_range_safe(range__, next__, notifier__, start__, end__) \
+ for ((range__) = drm_gpusvm_range_find((notifier__), (start__), (end__)), \
+ (next__) = __drm_gpusvm_range_next(range__); \
+ (range__) && (drm_gpusvm_range_start(range__) < (end__)); \
+ (range__) = (next__), (next__) = __drm_gpusvm_range_next(range__))
-:600: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'notifier__' - possible side-effects?
#600: FILE: drivers/gpu/drm/drm_gpusvm.c:448:
+#define drm_gpusvm_for_each_notifier(notifier__, gpusvm__, start__, end__) \
+ for ((notifier__) = notifier_iter_first(&(gpusvm__)->root, (start__), (end__) - 1); \
+ (notifier__) && (drm_gpusvm_notifier_start(notifier__) < (end__)); \
+ (notifier__) = __drm_gpusvm_notifier_next(notifier__))
-:600: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'end__' - possible side-effects?
#600: FILE: drivers/gpu/drm/drm_gpusvm.c:448:
+#define drm_gpusvm_for_each_notifier(notifier__, gpusvm__, start__, end__) \
+ for ((notifier__) = notifier_iter_first(&(gpusvm__)->root, (start__), (end__) - 1); \
+ (notifier__) && (drm_gpusvm_notifier_start(notifier__) < (end__)); \
+ (notifier__) = __drm_gpusvm_notifier_next(notifier__))
-:616: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'notifier__' - possible side-effects?
#616: FILE: drivers/gpu/drm/drm_gpusvm.c:464:
+#define drm_gpusvm_for_each_notifier_safe(notifier__, next__, gpusvm__, start__, end__) \
+ for ((notifier__) = notifier_iter_first(&(gpusvm__)->root, (start__), (end__) - 1), \
+ (next__) = __drm_gpusvm_notifier_next(notifier__); \
+ (notifier__) && (drm_gpusvm_notifier_start(notifier__) < (end__)); \
+ (notifier__) = (next__), (next__) = __drm_gpusvm_notifier_next(notifier__))
-:616: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'next__' - possible side-effects?
#616: FILE: drivers/gpu/drm/drm_gpusvm.c:464:
+#define drm_gpusvm_for_each_notifier_safe(notifier__, next__, gpusvm__, start__, end__) \
+ for ((notifier__) = notifier_iter_first(&(gpusvm__)->root, (start__), (end__) - 1), \
+ (next__) = __drm_gpusvm_notifier_next(notifier__); \
+ (notifier__) && (drm_gpusvm_notifier_start(notifier__) < (end__)); \
+ (notifier__) = (next__), (next__) = __drm_gpusvm_notifier_next(notifier__))
-:616: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'end__' - possible side-effects?
#616: FILE: drivers/gpu/drm/drm_gpusvm.c:464:
+#define drm_gpusvm_for_each_notifier_safe(notifier__, next__, gpusvm__, start__, end__) \
+ for ((notifier__) = notifier_iter_first(&(gpusvm__)->root, (start__), (end__) - 1), \
+ (next__) = __drm_gpusvm_notifier_next(notifier__); \
+ (notifier__) && (drm_gpusvm_notifier_start(notifier__) < (end__)); \
+ (notifier__) = (next__), (next__) = __drm_gpusvm_notifier_next(notifier__))
-:2405: WARNING:CONFIG_DESCRIPTION: please write a help paragraph that fully describes the config symbol
#2405: FILE: drivers/gpu/drm/xe/Kconfig:77:
+config DRM_XE_DEVMEM_MIRROR
+ bool "Enable device memory mirror"
+ depends on DRM_XE
+ select GET_FREE_REGION
+ default y
+ help
+ Disable this option only if you want to compile out without device
+ memory mirror. Will reduce KMD memory footprint when disabled.
+
-:3835: WARNING:REPEATED_WORD: Possible repeated word: 'for'
#3835: FILE: drivers/gpu/drm/xe/xe_res_cursor.h:56:
+ /** @sgl: Scatterlist for for cursor */
-:4048: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'r__' - possible side-effects?
#4048: FILE: drivers/gpu/drm/xe/xe_svm.c:53:
+#define range_debug(r__, operaton__) \
+ vm_dbg(&range_to_vm(&(r__)->base)->xe->drm, \
+ "%s: asid=%u, gpusvm=%p, vram=%d,%d, seqno=%lu, " \
+ "start=0x%014lx, end=0x%014lx, size=%lu", \
+ (operaton__), range_to_vm(&(r__)->base)->usm.asid, \
+ (r__)->base.gpusvm, \
+ xe_svm_range_in_vram((r__)) ? 1 : 0, \
+ xe_svm_range_has_vram_binding((r__)) ? 1 : 0, \
+ (r__)->base.notifier_seq, \
+ xe_svm_range_start((r__)), xe_svm_range_end((r__)), \
+ xe_svm_range_size((r__)))
-:4348: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#4348: FILE: drivers/gpu/drm/xe/xe_svm.c:353:
+static u64 xe_vram_region_page_to_dpa(struct xe_vram_region *vr,
+ struct page *page)
-:6335: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gpusvm' - possible side-effects?
#6335: FILE: include/drm/drm_gpusvm.h:374:
+#define drm_gpusvm_driver_set_lock(gpusvm, lock) \
+ do { \
+ if (!WARN((gpusvm)->lock_dep_map, \
+ "GPUSVM range lock should be set only once."))\
+ (gpusvm)->lock_dep_map = &(lock)->dep_map; \
+ } while (0)
-:6342: WARNING:MACRO_ARG_UNUSED: Argument 'gpusvm' is not used in function-like macro
#6342: FILE: include/drm/drm_gpusvm.h:381:
+#define drm_gpusvm_driver_set_lock(gpusvm, lock) do {} while (0)
-:6342: WARNING:MACRO_ARG_UNUSED: Argument 'lock' is not used in function-like macro
#6342: FILE: include/drm/drm_gpusvm.h:381:
+#define drm_gpusvm_driver_set_lock(gpusvm, lock) do {} while (0)
-:6464: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'range__' - possible side-effects?
#6464: FILE: include/drm/drm_gpusvm.h:503:
+#define drm_gpusvm_for_each_range(range__, notifier__, start__, end__) \
+ for ((range__) = (range__) ?: \
+ drm_gpusvm_range_find((notifier__), (start__), (end__)); \
+ (range__) && (drm_gpusvm_range_start(range__) < (end__)); \
+ (range__) = __drm_gpusvm_range_next(range__))
-:6464: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'end__' - possible side-effects?
#6464: FILE: include/drm/drm_gpusvm.h:503:
+#define drm_gpusvm_for_each_range(range__, notifier__, start__, end__) \
+ for ((range__) = (range__) ?: \
+ drm_gpusvm_range_find((notifier__), (start__), (end__)); \
+ (range__) && (drm_gpusvm_range_start(range__) < (end__)); \
+ (range__) = __drm_gpusvm_range_next(range__))
-:6854: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#6854: FILE: mm/migrate_device.c:878:
+void migrate_device_finalize(unsigned long *src_pfns,
+ unsigned long *dst_pfns, unsigned long npages)
total: 0 errors, 7 warnings, 14 checks, 6617 lines checked
More information about the Intel-xe
mailing list