[PATCH RESEND v3] drm/xe: xe_gen_wa_oob: replace program_invocation_short_name
Lucas De Marchi
lucas.demarchi at intel.com
Thu Feb 27 19:09:55 UTC 2025
On Thu, Feb 27, 2025 at 08:39:21AM -0500, Tamir Duberstein wrote:
>Hi Lucas, chiming in here since I also care about building on macOS.
>
>On Mon, Feb 24, 2025 at 10:05 AM Lucas De Marchi
><lucas.demarchi at intel.com> wrote:
>>
>> Is this the approach taken for other similar issues you had? Note that
>> argv[0] and program_invocation_short_name are not the same thing. For
>> this particular binary I don't really care and if it's the approach
>> taken in other places, I'm ok using it.
>
>Believe it or not, this is the only place that
>program_invocation_short_name has ever been used in the kernel. There
>have been numerous instances of:
>
>#define _GNU_SOURCE /* for program_invocation_short_name */
>
>but never any actual callers (that I could find in the git history)
>other than this one.
>
>> I was expecting you'd take the acks and merge it all through a single
>> tree since you received push back on the need to build the kernel in
>> macOS. Is this the only thing missing and you'd want it to go through
>> drm?
>
>I believe the other patches have been applied or dropped. When I last
>tested building allmodconfig this was the only issue I ran into (macOS
>arm64), so I asked Daniel for this resend.
fair enough. Pushed to drm-xe-next since nobody ever reads the
usage for this helper tool and it doesn't really matter if now it's ugly.
Lucas De Marchi
>
>Cheers.
>Tamir
More information about the Intel-xe
mailing list