[PATCH v3 1/1] drm/xe/guc: Fix GuC log/ct output via debugfs

[Lucas De Marchi]

On Tue, Jan 07, 2025 at 12:22:52PM -0800, Julia Filipchuk wrote:
>Change to disable asci85 GuC logging only when output to devcoredump
>(was temporarily disabled for all code paths).
>
>v2: Ignore only for devcoredump case (not dmesg output).
>v3: Rebase to resolve parent tag mismatch.
>
>Signed-off-by: Julia Filipchuk <julia.filipchuk at intel.com>
>---
> drivers/gpu/drm/xe/xe_devcoredump.c | 8 +++++---
> include/drm/drm_print.h             | 2 ++
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
>index 6980304c8903..8e5d1f9866a7 100644
>--- a/drivers/gpu/drm/xe/xe_devcoredump.c
>+++ b/drivers/gpu/drm/xe/xe_devcoredump.c
>@@ -424,10 +424,12 @@ void xe_print_blob_ascii85(struct drm_printer *p, const char *prefix,
> 	 * Splitting blobs across multiple lines is not compatible with the mesa
> 	 * debug decoder tool. Note that even dropping the explicit '\n' below
> 	 * doesn't help because the GuC log is so big some underlying implementation
>-	 * still splits the lines at 512K characters. So just bail completely for
>-	 * the moment.
>+	 * still splits the lines at 512K characters.

did we investigate where this is done and how we can overcome it? I
understand having to split it into multiple calls, but not something
adding a \n. particularly for the functions dealing with seq_file and
devcoredump.

>+	 *
>+	 * Only disable from devcoredump output.
> 	 */
>-	return;
>+	if (p->coredump)

but we do want the guc log to be inside the devcoredump, so rather than
adding more workarounds, can we fix it ?

Lucas De Marchi