[PATCH v2 2/3] drm/xe: Enable Boot Survivability mode
Riana Tauro
riana.tauro at intel.com
Wed Jan 8 10:39:58 UTC 2025
Enable boot survivability mode if pcode initialization fails and
if boot status indicates a failure. In this mode, drm card is not
exposed and driver probe returns success after loading the bare minimum
to allow firmware to be flashed via mei.
v2: abstract survivability mode variable
add BMG check inside function (Jani, Rodrigo)
Signed-off-by: Riana Tauro <riana.tauro at intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
drivers/gpu/drm/xe/xe_device.c | 9 +++++++--
drivers/gpu/drm/xe/xe_pci.c | 13 +++++++++++++
drivers/gpu/drm/xe/xe_survivability_mode.c | 16 ++++++++++++++++
drivers/gpu/drm/xe/xe_survivability_mode.h | 1 +
4 files changed, 37 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index bf36e4fb4679..6a4d76533555 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -51,6 +51,7 @@
#include "xe_pm.h"
#include "xe_query.h"
#include "xe_sriov.h"
+#include "xe_survivability_mode.h"
#include "xe_tile.h"
#include "xe_ttm_stolen_mgr.h"
#include "xe_ttm_sys_mgr.h"
@@ -587,8 +588,12 @@ int xe_device_probe_early(struct xe_device *xe)
update_device_info(xe);
err = xe_pcode_probe_early(xe);
- if (err)
- return err;
+ if (err) {
+ if (xe_survivability_mode_required(xe))
+ xe_survivability_mode_init(xe);
+
+ return xe_survivability_mode_enabled(xe) ? 0 : err;
+ }
err = wait_for_lmem_ready(xe);
if (err)
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 7d146e3e8e21..f2637d8a71eb 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -30,6 +30,7 @@
#include "xe_pm.h"
#include "xe_sriov.h"
#include "xe_step.h"
+#include "xe_survivability_mode.h"
#include "xe_tile.h"
enum toggle_d3cold {
@@ -768,6 +769,9 @@ static void xe_pci_remove(struct pci_dev *pdev)
if (IS_SRIOV_PF(xe))
xe_pci_sriov_configure(pdev, 0);
+ if (xe_survivability_mode_enabled(xe))
+ return xe_survivability_mode_remove(xe);
+
xe_device_remove(xe);
xe_pm_runtime_fini(xe);
pci_set_drvdata(pdev, NULL);
@@ -840,6 +844,15 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
return err;
err = xe_device_probe_early(xe);
+
+ /*
+ * In Boot Survivability mode, no drm card is exposed
+ * and driver is loaded with bare minimum to allow
+ * for firmware to be flashed through mei
+ */
+ if (!err && xe_survivability_mode_enabled(xe))
+ return 0;
+
if (err)
return err;
diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
index 077422ae009d..4a978c7018c9 100644
--- a/drivers/gpu/drm/xe/xe_survivability_mode.c
+++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
@@ -154,6 +154,19 @@ static void enable_survivability_mode(struct xe_device *xe)
}
}
+/**
+ * xe_survivability_mode_enabled - check if survivability mode is enabled
+ * @xe: xe device instance
+ *
+ * Returns true if in survivability mode, false otherwise
+ */
+bool xe_survivability_mode_enabled(struct xe_device *xe)
+{
+ struct xe_survivability *survivability = &xe->survivability;
+
+ return survivability->mode;
+}
+
/**
* xe_survivability_mode_required- checks if survivability mode is required
* @xe: xe device instance
@@ -168,6 +181,9 @@ bool xe_survivability_mode_required(struct xe_device *xe)
struct xe_mmio *mmio = xe_root_tile_mmio(xe);
u32 data;
+ if (!IS_DGFX(xe) || xe->info.platform < XE_BATTLEMAGE)
+ return false;
+
data = xe_mmio_read32(mmio, PCODE_SCRATCH_ADDR(0));
survivability->boot_status = REG_FIELD_GET(BOOT_STATUS, data);
diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.h b/drivers/gpu/drm/xe/xe_survivability_mode.h
index 410e3ee5f5d1..f530507a22c6 100644
--- a/drivers/gpu/drm/xe/xe_survivability_mode.h
+++ b/drivers/gpu/drm/xe/xe_survivability_mode.h
@@ -12,6 +12,7 @@ struct xe_device;
void xe_survivability_mode_init(struct xe_device *xe);
void xe_survivability_mode_remove(struct xe_device *xe);
+bool xe_survivability_mode_enabled(struct xe_device *xe);
bool xe_survivability_mode_required(struct xe_device *xe);
#endif /* _XE_SURVIVABILITY_MODE_H_ */
--
2.47.1
More information about the Intel-xe
mailing list