✗ CI.checkpatch: warning for drm/xe/guc: Use exec queue hints for GT frequency (rev2)

[Patchwork]

== Series Details ==

Series: drm/xe/guc: Use exec queue hints for GT frequency (rev2)
URL   : https://patchwork.freedesktop.org/series/143323/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit dec08486113f0b94d990fd996fb17543582dc7e3
Author: Tejas Upadhyay <tejas.upadhyay at intel.com>
Date:   Thu Jan 9 17:37:05 2025 +0530

    drm/xe/guc: Use exec queue hints for GT frequency
    
    Allow user to provide a low latency hint per exec queue. When set,
    KMD sends a hint to GuC which results in special handling for this
    exec queue. SLPC will ramp the GT frequency aggressively every time
    it switches to this exec queue.
    
    We need to enable the use of SLPC Compute strategy during init, but
    it will apply only to exec queues that set this bit during exec queue
    creation.
    
    Improvement with this approach as below:
    
    Before,
    
    :~$ NEOReadDebugKeys=1 EnableDirectSubmission=0 clpeak --kernel-latency
    Platform: Intel(R) OpenCL Graphics
      Device: Intel(R) Graphics [0xe20b]
        Driver version  : 24.52.0 (Linux x64)
        Compute units   : 160
        Clock frequency : 2850 MHz
        Kernel launch latency : 283.16 us
    
    After,
    
    :~$ NEOReadDebugKeys=1 EnableDirectSubmission=0 clpeak --kernel-latency
    Platform: Intel(R) OpenCL Graphics
      Device: Intel(R) Graphics [0xe20b]
        Driver version  : 24.52.0 (Linux x64)
        Compute units   : 160
        Clock frequency : 2850 MHz
    
        Kernel launch latency : 63.38 us
    
    UMD will indicate low latency hint with flag as mentioned below,
    
    *     struct drm_xe_exec_queue_create exec_queue_create = {
    *          .flags = DRM_XE_EXEC_QUEUE_LOW_LATENCY_HINT or 0
    *          .extensions = 0,
    *          .vm_id = vm,
    *          .num_bb_per_exec = 1,
    *          .num_eng_per_bb = 1,
    *          .instances = to_user_pointer(&instance),
    *     };
    *     ioctl(fd, DRM_IOCTL_XE_EXEC_QUEUE_CREATE, &exec_queue_create);
    
    Link to UMD PR : https://github.com/intel/compute-runtime/pull/794
    
    Note: There is outstanding issue on guc side to be not able to switch to max
    frequency as per strategy indicated by KMD, so for experminet/test result
    hardcoding apporch was taken and passed to guc as policy. Effort on debugging
    from guc side is going on in parallel.
    
    V2:
      - DRM_XE_EXEC_QUEUE_LOW_LATENCY_HINT 1 is already planned for other hint(Szymon)
      - Add motivation to description (Lucas)
    
    Cc:dri-devel at lists.freedesktop.org
    Cc:vinay.belgaumkar at intel.com
    Cc:Michal Mrozek <michal.mrozek at intel.com>
    Cc:Szymon Morek <szymon.morek at intel.com>
    Cc:José Roberto de Souza <jose.souza at intel.com>
    Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
    Acked-by: Michal Mrozek <michal.mrozek at intel.com>
+ /mt/dim checkpatch c9da975358cd0763449f08b7063ee935eace4f8c drm-intel
dec08486113f drm/xe/guc: Use exec queue hints for GT frequency
-:55: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#55: 
Note: There is outstanding issue on guc side to be not able to switch to max

-:64: WARNING:BAD_SIGN_OFF: Use a single space after Cc:
#64: 
Cc:dri-devel at lists.freedesktop.org

-:65: WARNING:BAD_SIGN_OFF: Use a single space after Cc:
#65: 
Cc:vinay.belgaumkar at intel.com

-:66: WARNING:BAD_SIGN_OFF: Use a single space after Cc:
#66: 
Cc:Michal Mrozek <michal.mrozek at intel.com>

-:67: WARNING:BAD_SIGN_OFF: Use a single space after Cc:
#67: 
Cc:Szymon Morek <szymon.morek at intel.com>

-:68: WARNING:BAD_SIGN_OFF: Use a single space after Cc:
#68: 
Cc:José Roberto de Souza <jose.souza at intel.com>

total: 0 errors, 6 warnings, 0 checks, 116 lines checked