✗ CI.checkpatch: warning for drm/xe/client: Better correlate exec_queue and GT timestamps (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Thu Jan 9 22:38:44 UTC 2025
== Series Details ==
Series: drm/xe/client: Better correlate exec_queue and GT timestamps (rev2)
URL : https://patchwork.freedesktop.org/series/142501/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 63c2ab13c3332c72631160db4af3654ea5e71930
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date: Thu Jan 9 12:03:40 2025 -0800
drm/xe/client: Better correlate exec_queue and GT timestamps
This partially reverts commit fe4f5d4b6616 ("drm/xe: Clean up VM / exec
queue file lock usage."). While it's desired to have the mutex to
protect only the reference to the exec queue, getting and dropping each
mutex and then later getting the GPU timestamp, doesn't produce a
correct result: it introduces multiple opportunities for the task to be
scheduled out and thus wrecking havoc the deltas reported to userspace.
Also, to better correlate the timestamp from the exec queues with the
GPU, disable preemption so they can be updated without allowing the task
to be scheduled out. We leave interrupts enabled as that shouldn't be
enough disturbance for the deltas to matter to userspace.
Test scenario:
* IGT'S `xe_drm_fdinfo --r utilization-single-full-load`
* Platform: LNL, where CI occasionally reports failures
* `stress -c $(nproc)` running in parallel to disturb the
system
This brings a first failure from "after ~150 executions" to "never
occurs after 1000 attempts".
v2: Also keep xe_hw_engine_read_timestamp() call inside the
preemption-disabled section (Umesh)
Cc: stable at vger.kernel.org # v6.11+
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3512
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch cf64efebee4a827f4861ca82104544e7cff460fd drm-intel
63c2ab13c333 drm/xe/client: Better correlate exec_queue and GT timestamps
-:67: WARNING:MISSING_FIXES_TAG: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag?
total: 0 errors, 1 warnings, 0 checks, 26 lines checked
More information about the Intel-xe
mailing list