✗ CI.checkpatch: warning for treewide: const qualify ctl_tables where applicable (rev2)

[Patchwork]

== Series Details ==

Series: treewide: const qualify ctl_tables where applicable (rev2)
URL   : https://patchwork.freedesktop.org/series/143333/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 41ee812bcb9a4c0b379344c48794930a372972ba
Author: Joel Granados <joel.granados at kernel.org>
Date:   Fri Jan 10 15:16:08 2025 +0100

    treewide: const qualify ctl_tables where applicable
    
    Add the const qualifier to all the ctl_tables in the tree except for
    watchdog_hardlockup_sysctl, memory_allocation_profiling_sysctls,
    loadpin_sysctl_table and the ones calling register_net_sysctl (./net,
    drivers/inifiniband dirs). These are special cases as they use a
    registration function with a non-const qualified ctl_table argument or
    modify the arrays before passing them on to the registration function.
    
    Constifying ctl_table structs will prevent the modification of
    proc_handler function pointers as the arrays would reside in .rodata.
    This is made possible after commit 78eb4ea25cd5 ("sysctl: treewide:
    constify the ctl_table argument of proc_handlers") constified all the
    proc_handlers.
    
    Created this by running an spatch followed by a sed command:
    Spatch:
        virtual patch
    
        @
        depends on !(file in "net")
        disable optional_qualifier
        @
        identifier table_name != {watchdog_hardlockup_sysctl,iwcm_ctl_table,ucma_ctl_table,memory_allocation_profiling_sysctls,loadpin_sysctl_table};
        @@
    
        + const
        struct ctl_table table_name [] = { ... };
    
    sed:
        sed --in-place \
          -e "s/struct ctl_table .table = &uts_kern/const struct ctl_table *table = \&uts_kern/" \
          kernel/utsname_sysctl.c
    
    Reviewed-by: Song Liu <song at kernel.org>
    Acked-by: Steven Rostedt (Google) <rostedt at goodmis.org> # for kernel/trace/
    Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com> # SCSI
    Reviewed-by: Darrick J. Wong <djwong at kernel.org> # xfs
    Acked-by: Jani Nikula <jani.nikula at intel.com>
    Acked-by: Corey Minyard <cminyard at mvista.com>
    Signed-off-by: Joel Granados <joel.granados at kernel.org>
+ /mt/dim checkpatch 00f4619246294b1de4bac42742cfef95c1f37fde drm-intel
41ee812bcb9a treewide: const qualify ctl_tables where applicable
-:27: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#27: 
    identifier table_name != {watchdog_hardlockup_sysctl,iwcm_ctl_table,ucma_ctl_table,memory_allocation_profiling_sysctls,loadpin_sysctl_table};

-:424: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#424: FILE: drivers/misc/sgi-xp/xpc_main.c:114:
 };
+static const struct ctl_table xpc_sys_xpc[] = {

-:1204: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#1204: FILE: kernel/stackleak.c:47:
 }
+static const struct ctl_table stackleak_sysctls[] = {

total: 0 errors, 1 warnings, 2 checks, 920 lines checked