[PATCH] drm/xe: Fix a typo in xe_vm_doc.h
Maciej Patelczyk
maciej.patelczyk at intel.com
Tue Jan 14 09:06:51 UTC 2025
On 13.01.2025 22:23, Oak Zeng wrote:
> s/vm->ttm.base.resv->lock/vm->gpuvm.r_obj->resv->lock
>
> Signed-off-by: Oak Zeng <oak.zeng at intel.com>
> ---
> drivers/gpu/drm/xe/xe_vm_doc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm_doc.h b/drivers/gpu/drm/xe/xe_vm_doc.h
> index 078786958403..1030ce214032 100644
> --- a/drivers/gpu/drm/xe/xe_vm_doc.h
> +++ b/drivers/gpu/drm/xe/xe_vm_doc.h
> @@ -431,7 +431,7 @@
> * bind path also acquires this lock in write while the exec / compute mode
> * rebind worker acquires this lock in read mode.
> *
> - * VM dma-resv lock (vm->ttm.base.resv->lock) - WW lock. Protects VM dma-resv
> + * VM dma-resv lock (vm->gpuvm.r_obj->resv->lock) - WW lock. Protects VM dma-resv
> * slots which is shared with any private BO in the VM. Expected to be acquired
> * during VM binds, execs, and compute mode rebind worker. This lock is also
> * held when private BOs are being evicted.
Indeed it is a not correct. The ttm.base is always linked with BO.
However the gpuvm.r_obj is
passed to drm_exec_lock_obj() so internals are later hidden.
Reviewed-by: Maciej Patelczyk <maciej.patelczyk at intel.com>
More information about the Intel-xe
mailing list