✗ CI.checkpatch: warning for Buiild error in i915/xe (was: [PATCH next 4/7] minmax.h: Use BUILD_BUG_ON_MSG() for the lo < hi test in clamp())
Patchwork
patchwork at emeril.freedesktop.org
Sat Jan 18 17:56:45 UTC 2025
== Series Details ==
Series: Buiild error in i915/xe (was: [PATCH next 4/7] minmax.h: Use BUILD_BUG_ON_MSG() for the lo < hi test in clamp())
URL : https://patchwork.freedesktop.org/series/143702/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 20f727ebe0d34e3f1b19e2ae7cdeda09f371571c
Author: Guenter Roeck <linux at roeck-us.net>
Date: Sat Jan 18 09:49:21 2025 -0800
Buiild error in i915/xe (was: [PATCH next 4/7] minmax.h: Use BUILD_BUG_ON_MSG() for the lo < hi test in clamp())
On Sat, Jan 18, 2025 at 05:09:59PM +0000, David Laight wrote:
> On Sat, 18 Jan 2025 08:13:06 -0800
> Guenter Roeck <linux at roeck-us.net> wrote:
>
> > Hi,
> >
> > On Mon, Nov 18, 2024 at 07:13:31PM +0000, David Laight wrote:
> > > Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity
> > > check of the bounds in clamp().
> > > Gives better error coverage and one less expansion of the arguments.
> > >
> > > Signed-off-by: David Laight <david.laight at aculab.com>
> >
> > This patch triggers a build error when trying to build parisc:allmodconfig.
> > See error message and bisect log below.
> >
> > I don't think there is anything wrong with the patch. The underlying
> > problem seems to be that parisc:allmodconfig enables CONFIG_DRM_XE which
> > tries to build the affected file even though CONFIG_DRM_I915 is not
> > enabled/supported on parisc.
>
> This has appeared before.
> Any idea which inlined copy of scale() is causing the problem.
> On the face of it they all look ok.
>
> If you can reproduce it maybe try commenting out some of the calls.
>
See diff below. All three changes are needed.
No idea why the compiler would know that the values are invalid.
Guenter
+ /mt/dim checkpatch 4fc988de9f5e17d19edb5fc0a0fbc15a8fc837f4 drm-intel
20f727ebe0d3 Buiild error in i915/xe (was: [PATCH next 4/7] minmax.h: Use BUILD_BUG_ON_MSG() for the lo < hi test in clamp())
-:20: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#20:
> > This patch triggers a build error when trying to build parisc:allmodconfig.
-:48: WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#48: FILE: drivers/gpu/drm/i915/display/intel_backlight.c:79:
+#if 0
-:63: WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#63: FILE: drivers/gpu/drm/i915/display/intel_backlight.c:126:
+#if 0
-:74: WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#74: FILE: drivers/gpu/drm/i915/display/intel_backlight.c:147:
+#if 0
-:82: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 4 warnings, 0 checks, 36 lines checked
More information about the Intel-xe
mailing list