[PATCH] drm/xe/guc: Fix sizeof(32) typo

Summers, Stuart stuart.summers at intel.com
Tue Jan 21 17:39:28 UTC 2025


On Tue, 2025-01-21 at 10:48 +0100, Michal Wajdeczko wrote:
> A small typo leads to the following static code checker warning:
> 
>         drivers/gpu/drm/xe/xe_guc_buf.c:81 xe_guc_buf_reserve()
>         warn: sizeof(NUMBER)?
> 
> Reported-by: Dan Carpenter <dan.carpenter at linaro.org>
> Closes:
> https://lore.kernel.org/intel-xe/0d5bcbf1-79f9-4a10-a221-ddbaec9f6122@stanley.mountain/
> Fixes: 696bfdf273ea ("drm/xe/guc: Introduce the GuC Buffer Cache")
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Dan Carpenter <dan.carpenter at linaro.org>
> Cc: Matthew Brost <matthew.brost at intel.com>

Reviewed-by: Stuart Summers <stuart.summers at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_buf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_buf.c
> b/drivers/gpu/drm/xe/xe_guc_buf.c
> index ce6d9830e13b..0193c94dd6a0 100644
> --- a/drivers/gpu/drm/xe/xe_guc_buf.c
> +++ b/drivers/gpu/drm/xe/xe_guc_buf.c
> @@ -78,7 +78,7 @@ struct xe_guc_buf xe_guc_buf_reserve(struct
> xe_guc_buf_cache *cache, u32 dwords)
>         struct drm_suballoc *sa;
>  
>         if (cache->sam)
> -               sa = __xe_sa_bo_new(cache->sam, dwords * sizeof(32),
> GFP_ATOMIC);
> +               sa = __xe_sa_bo_new(cache->sam, dwords * sizeof(u32),
> GFP_ATOMIC);
>         else
>                 sa = ERR_PTR(-EOPNOTSUPP);
>  



More information about the Intel-xe mailing list