[PATCH 3/3] Partially revert "drm/xe: Revert some changes that break a mesa debug tool"

John.C.Harrison at Intel.com John.C.Harrison at Intel.com
Wed Jan 22 21:46:01 UTC 2025


From: John Harrison <John.C.Harrison at Intel.com>

This reverts part of commit a53da2fb25a31f4fb8eaeb93c7b1134fc14fd209.

The KMD has been updated to avoid the line wrapping issue of the mesa
tool. The section heading issue has not been fixed yet, however. So
that part of the original revert remains.

Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
---
 drivers/gpu/drm/xe/xe_devcoredump.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
index 18a7ddb561d8..81a461d62770 100644
--- a/drivers/gpu/drm/xe/xe_devcoredump.c
+++ b/drivers/gpu/drm/xe/xe_devcoredump.c
@@ -420,15 +420,6 @@ void xe_print_blob_ascii85(struct drm_printer *p, const char *prefix,
 	char buff[ASCII85_BUFSZ], *line_buff;
 	size_t line_pos = 0;
 
-	/*
-	 * Splitting blobs across multiple lines is not compatible with the mesa
-	 * debug decoder tool. Note that even dropping the explicit '\n' below
-	 * doesn't help because the GuC log is so big some underlying implementation
-	 * still splits the lines at 512K characters. So just bail completely for
-	 * the moment.
-	 */
-	return;
-
 #define DMESG_MAX_LINE_LEN	800
 #define MIN_SPACE		(ASCII85_BUFSZ + 2)		/* 85 + "\n\0" */
 
-- 
2.47.0



More information about the Intel-xe mailing list