[PATCH v2 1/3] drm/xe/guc: Explicitly name each chunk of GuC log data in a dump

John.C.Harrison at Intel.com John.C.Harrison at Intel.com
Wed Jan 22 23:33:02 UTC 2025


From: John Harrison <John.C.Harrison at Intel.com>

A mesa devcoredump decoding tool does not cope with line wrapped
ASCII85 data. The GuC log is saved and printed in chunks. Only the
first chunk was named, thus subsequent chunks were effectively line
wrapped data. So add names to all the chunks instead.

v2: Fix size of name variable.

Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
---
 drivers/gpu/drm/xe/xe_guc_log.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_log.c b/drivers/gpu/drm/xe/xe_guc_log.c
index 80151ff6a71f..d10ba20685fe 100644
--- a/drivers/gpu/drm/xe/xe_guc_log.c
+++ b/drivers/gpu/drm/xe/xe_guc_log.c
@@ -207,8 +207,10 @@ void xe_guc_log_snapshot_print(struct xe_guc_log_snapshot *snapshot, struct drm_
 	remain = snapshot->size;
 	for (i = 0; i < snapshot->num_chunks; i++) {
 		size_t size = min(GUC_LOG_CHUNK_SIZE, remain);
+		char name[22];
 
-		xe_print_blob_ascii85(p, i ? NULL : "Log data", snapshot->copy[i], 0, size);
+		snprintf(name, sizeof(name), "Log data %d", i);
+		xe_print_blob_ascii85(p, name, snapshot->copy[i], 0, size);
 		remain -= size;
 	}
 }
-- 
2.47.0



More information about the Intel-xe mailing list