✗ CI.checkpatch: warning for drm/sched: Use struct for drm_sched_init() params

Patchwork patchwork at emeril.freedesktop.org
Thu Jan 23 10:55:49 UTC 2025


== Series Details ==

Series: drm/sched: Use struct for drm_sched_init() params
URL   : https://patchwork.freedesktop.org/series/143883/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit e4e7cf9ab13d54d11e6f53b89e0dd2f9e0b96e88
Author: Philipp Stanner <phasta at kernel.org>
Date:   Wed Jan 22 15:08:20 2025 +0100

    drm/sched: Use struct for drm_sched_init() params
    
    drm_sched_init() has a great many parameters and upcoming new
    functionality for the scheduler might add even more. Generally, the
    great number of parameters reduces readability and has already caused
    one missnaming in:
    
    commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in nouveau_sched_init()").
    
    Introduce a new struct for the scheduler init parameters and port all
    users.
    
    Signed-off-by: Philipp Stanner <phasta at kernel.org>
+ /mt/dim checkpatch 79f0f76f7f03b0667e10fe2fa3a75b2f8727b8de drm-intel
e4e7cf9ab13d drm/sched: Use struct for drm_sched_init() params
-:11: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#11: 
commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in nouveau_sched_init()").

-:472: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#472: FILE: drivers/gpu/drm/scheduler/sched_main.c:1285:
+		sched->submit_wq = alloc_ordered_workqueue_lockdep_map(

total: 0 errors, 1 warnings, 1 checks, 686 lines checked




More information about the Intel-xe mailing list