✗ CI.checkpatch: warning for drm/i915: intel_display conversions and some debug improvements

[Patchwork]

== Series Details ==

Series: drm/i915: intel_display conversions and some debug improvements
URL   : https://patchwork.freedesktop.org/series/143941/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 28324956ce72b34551c55debc3c66f8b80cb327a
Author: Ville Syrjälä <ville.syrjala at linux.intel.com>
Date:   Fri Jan 24 18:30:40 2025 +0200

    drm/i915: Pimp plane debugs
    
    Include the standard "[PLANE:%d:s]" stuff in all plane debugs
    (or rather all I was able to find), to provide better information
    on which plane we're actually talking about.
    
    There are a few spots where we care about the CRTC as well, so
    include that where appropriate.
    
    Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
+ /mt/dim checkpatch b36df02c99e3246ba2a90e951c71797327374db7 drm-intel
84ab094f5c1b drm/i915: Decouple i915_gem_dumb_create() from the display a bit
6d197cbd9a8d drm/i915: Decouple intel_fb_bo.h interfaces from driver specific types
950e00c46c2a drm/i915: Convert intel_crtc.c to struct intel_display
777b86ea5c62 drm/i915: Convert intel_fb.c to struct intel_display
-:436: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects?
#436: FILE: drivers/gpu/drm/i915/display/intel_fb.c:1467:
+#define assign_bfld_chk_ovf(display, var, val) ({ \
 	(var) = (val); \
+	drm_WARN_ON((display)->drm, (var) != (val)); \
 	(var); \
 })

-:436: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#436: FILE: drivers/gpu/drm/i915/display/intel_fb.c:1467:
+#define assign_bfld_chk_ovf(display, var, val) ({ \
 	(var) = (val); \
+	drm_WARN_ON((display)->drm, (var) != (val)); \
 	(var); \
 })

total: 0 errors, 0 warnings, 2 checks, 878 lines checked
b50116fbbf98 drm/i915: Convert intel_display_power_{get, put}*() to intel_display
-:1505: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'display' - possible side-effects?
#1505: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:299:
+#define with_intel_display_power(display, domain, wf) \
+	for ((wf) = intel_display_power_get((display), (domain)); (wf); \
+	     intel_display_power_put_async((display), (domain), (wf)), (wf) = NULL)

-:1505: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'domain' - possible side-effects?
#1505: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:299:
+#define with_intel_display_power(display, domain, wf) \
+	for ((wf) = intel_display_power_get((display), (domain)); (wf); \
+	     intel_display_power_put_async((display), (domain), (wf)), (wf) = NULL)

-:1505: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects?
#1505: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:299:
+#define with_intel_display_power(display, domain, wf) \
+	for ((wf) = intel_display_power_get((display), (domain)); (wf); \
+	     intel_display_power_put_async((display), (domain), (wf)), (wf) = NULL)

-:1512: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'display' - possible side-effects?
#1512: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:303:
+#define with_intel_display_power_if_enabled(display, domain, wf) \
+	for ((wf) = intel_display_power_get_if_enabled((display), (domain)); (wf); \
+	     intel_display_power_put_async((display), (domain), (wf)), (wf) = NULL)

-:1512: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'domain' - possible side-effects?
#1512: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:303:
+#define with_intel_display_power_if_enabled(display, domain, wf) \
+	for ((wf) = intel_display_power_get_if_enabled((display), (domain)); (wf); \
+	     intel_display_power_put_async((display), (domain), (wf)), (wf) = NULL)

-:1512: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects?
#1512: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:303:
+#define with_intel_display_power_if_enabled(display, domain, wf) \
+	for ((wf) = intel_display_power_get_if_enabled((display), (domain)); (wf); \
+	     intel_display_power_put_async((display), (domain), (wf)), (wf) = NULL)

total: 0 errors, 0 warnings, 6 checks, 2358 lines checked
99722364c6e6 drm/i915: Convert i9xx_plane.c to struct intel_display
d49ab6f2253f drm/i915: Finish intel_sprite.c struct intel_display conversion
792cbd15cea8 drm/i915: Convert intel_cursor.c to struct intel_display
e438c832733f drm/i915: Convert skl_univeral_plane.c to struct intel_display
-:1129: WARNING:IS_ENABLED_CONFIG: IS_ENABLED(I915) is normally used as IS_ENABLED(CONFIG_I915)
#1129: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:2805:
+	if (!IS_ENABLED(I915) && !HAS_FLAT_CCS(to_i915(display->drm)))

total: 0 errors, 1 warnings, 0 checks, 1221 lines checked
fcad34b21029 drm/i915: Use DRM_RECT_FMT & co. for plane debugs
-:38: WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#38: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:963:
+		drm_dbg_kms(&i915->drm, "Plane (" DRM_RECT_FMT ") must cover entire CRTC (" DRM_RECT_FMT ")\n",

total: 0 errors, 1 warnings, 0 checks, 23 lines checked
28324956ce72 drm/i915: Pimp plane debugs
-:79: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#79: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:949:
+			    "[PLANE:%d:%s] invalid scaling "DRM_RECT_FP_FMT " -> " DRM_RECT_FMT "\n",

-:90: WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#90: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:966:
+			    "[PLANE:%d:%s] plane (" DRM_RECT_FMT ") must cover entire CRTC (" DRM_RECT_FMT ")\n",

total: 0 errors, 1 warnings, 1 checks, 378 lines checked