✗ CI.checkpatch: warning for drm/i915/display: Allow display PHYs to reset power state
Patchwork
patchwork at emeril.freedesktop.org
Wed Jan 29 14:47:10 UTC 2025
== Series Details ==
Series: drm/i915/display: Allow display PHYs to reset power state
URL : https://patchwork.freedesktop.org/series/144103/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit dbc1a9be7a2c4d66aa434320d555cee2e83404a0
Author: Mika Kahola <mika.kahola at intel.com>
Date: Wed Jan 29 15:01:05 2025 +0200
drm/i915/display: Allow display PHYs to reset power state
The dedicated display PHYs reset to a power state that blocks S0ix,
increasing idle system power. After a system reset (cold boot,
S3/4/5, warm reset) if a dedicated PHY is not being brought up
shortly, use these steps to move the PHY to the lowest power state
to save power.
1. Follow the PLL Enable Sequence, using any valid frequency such as DP 1.62 GHz.
This brings lanes out of reset and enables the PLL to allow powerdown to be moved
to the Disable state.
2. Follow PLL Disable Sequence. This moves powerdown to the Disable state and disables the PLL.
Signed-off-by: Mika Kahola <mika.kahola at intel.com>
+ /mt/dim checkpatch bdfc862a5c719d934efbdedb050ef891b9feef15 drm-intel
b058aca4ea7f drm/i915/display: Drop crtc_state from C10/C20 pll programming
-:53: WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#53: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy.c:2053:
+ const struct intel_c10pll_state * const *tables, int port_clock, bool is_dp,
-:94: WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#94: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy.c:2083:
+ crtc_state->port_clock, intel_crtc_has_dp_encoder(crtc_state),
-:248: WARNING:LONG_LINE: line length of 117 exceeds 100 columns
#248: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy.c:3092:
+ intel_crtc_has_dp_encoder(crtc_state), crtc_state->port_clock, crtc_state->lane_count);
-:250: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#250: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy.c:3094:
+
+}
total: 0 errors, 3 warnings, 1 checks, 225 lines checked
dbc1a9be7a2c drm/i915/display: Allow display PHYs to reset power state
-:12: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#12:
1. Follow the PLL Enable Sequence, using any valid frequency such as DP 1.62 GHz.
-:52: WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#52: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy.c:3587:
+ if (REG_FIELD_GET(XELPDP_DDI_CLOCK_SELECT_MASK, val) == XELPDP_DDI_CLOCK_SELECT_NONE) {
-:55: WARNING:LONG_LINE: line length of 126 exceeds 100 columns
#55: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy.c:3590:
+ intel_c10pll_calc_state_from_table(encoder, mtl_c10_edp_tables, port_clock, true, &pll_state);
-:55: WARNING:LINE_SPACING: Missing a blank line after declarations
#55: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy.c:3590:
+ int port_clock = 162000;
+ intel_c10pll_calc_state_from_table(encoder, mtl_c10_edp_tables, port_clock, true, &pll_state);
total: 0 errors, 4 warnings, 0 checks, 72 lines checked
More information about the Intel-xe
mailing list