[PATCH 2/4] drm/xe/gen12: Add Wa_1604555607

Tvrtko Ursulin tvrtko.ursulin at igalia.com
Thu Jan 30 11:03:35 UTC 2025


According to the i915 code base, apart from setting the GS timer, all
Gen12 platforms should also set the TDS timer. Make it so.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
References: 2b5298b0aa09 ("drm/i915/gen12: Add recommended hardware tuning value")
Cc: Lucas De Marchi <lucas.demarchi at intel.com>
Cc: Matt Roper <matthew.d.roper at intel.com>
---
This needs checking by someone with access to the proper docs and proper
workaround database.
---
 drivers/gpu/drm/xe/xe_tuning.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_tuning.c b/drivers/gpu/drm/xe/xe_tuning.c
index d449de0fb6ec..9e7ec36dbd47 100644
--- a/drivers/gpu/drm/xe/xe_tuning.c
+++ b/drivers/gpu/drm/xe/xe_tuning.c
@@ -97,12 +97,14 @@ static const struct xe_rtp_entry_sr engine_tunings[] = {
 };
 
 static const struct xe_rtp_entry_sr lrc_tunings[] = {
-	{ XE_RTP_NAME("Tuning: ganged timer, also known as 16011163337"),
+	{ XE_RTP_NAME("Tuning: ganged timers, also known as 16011163337 and 1604555607"),
 	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, 1210), ENGINE_CLASS(RENDER)),
 	  /* read verification is ignored due to 1608008084. */
 	  XE_RTP_ACTIONS(FIELD_SET_NO_READ_MASK(FF_MODE2,
-						FF_MODE2_GS_TIMER_MASK,
-						FF_MODE2_GS_TIMER_224))
+						FF_MODE2_GS_TIMER_MASK |
+						FF_MODE2_TDS_TIMER_MASK,
+						FF_MODE2_GS_TIMER_224 |
+						FF_MODE2_TDS_TIMER_128))
 	},
 
 	/* DG2 */
-- 
2.48.0



More information about the Intel-xe mailing list