✓ CI.checkpatch: success for drm/i915/vrr: Fix DSB+VRR usage for PTL+
Patchwork
patchwork at emeril.freedesktop.org
Thu Jan 30 19:13:33 UTC 2025
== Series Details ==
Series: drm/i915/vrr: Fix DSB+VRR usage for PTL+
URL : https://patchwork.freedesktop.org/series/144152/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit a09986c0798022b7fdba99410d99c06e27673fe1
Author: Ville Syrjälä <ville.syrjala at linux.intel.com>
Date: Thu Jan 30 20:45:18 2025 +0200
drm/i915/vrr: Poll for the push send bit to clear on the DSB
Since we now do the "wait for safe window" before triggering
the push send, there is a theoretical possibity that we may
have screwed up the vblank evasion and the push has slipped
past the vmax decision boundary. In that case the push would
only happen after the next frame's vactive, while we've
already signalled the flip to have completed via the DSB
interrupt immediately after triggering the push.
To make sure we catch such screwups let's poll for the push
send bit to clear. Assuming vblank delay has been dealt with
already it should clear within ~1 scanline. But for safety
let's give it ~2 scanlines. If the bit does not clear within
that time the DSB will raise the poll error interrupt to inform
us that something went wrong.
Also I suppose it might generally be a good idea to make sure
the send bit has cleared before we complete the commit because
we're not supposed to send a new push while the previous one
is still pending.
Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
+ /mt/dim checkpatch e0f6b9eac7e2d2df5801d9a0b591a4c6c809c5c6 drm-intel
718c4a0eb7a6 drm/i915/dsb: Introduce intel_dsb_poll()
9173d096748b drm/i915/vrr: Reorder the DSB "wait for safe window" vs. TRANS_PUSH
a09986c07980 drm/i915/vrr: Poll for the push send bit to clear on the DSB
More information about the Intel-xe
mailing list