[PATCH 0/7] Cleanup error handling on probe

Lucas De Marchi lucas.demarchi at intel.com
Fri Jan 31 22:31:33 UTC 2025


Mixing style with goto and devm_add_action_or_reset() is very confusing
and error prone. Clean that up. The only missing one is one of the
display calls, but that can be done in parallel to the review of these
first patches.

This received limited load/unload tests on LNL and may very well not be
100%.

Lucas De Marchi (7):
  drm/xe: Fix xe_display_fini() calls
  drm/xe: Fix error handling in xe_irq_install()
  drm/xe: Fix xe_tile_init_noalloc() error propagation
  drm/xe: Stop ignoring errors from xe_ttm_stolen_mgr_init()
  drm/xe: Cleanup unwind of gt initialization
  drm/xe: Cleanup extra calls to  xe_hw_fence_irq_finish()
  drm/xe: Move oa fini to xe_oa

 drivers/gpu/drm/xe/display/xe_display.c | 22 +++++-----
 drivers/gpu/drm/xe/display/xe_display.h |  2 -
 drivers/gpu/drm/xe/xe_device.c          | 53 ++++++++-----------------
 drivers/gpu/drm/xe/xe_gt.c              | 52 ++++++++++--------------
 drivers/gpu/drm/xe/xe_gt.h              |  1 -
 drivers/gpu/drm/xe/xe_irq.c             | 14 +------
 drivers/gpu/drm/xe/xe_oa.c              | 48 +++++++++++-----------
 drivers/gpu/drm/xe/xe_oa.h              |  1 -
 drivers/gpu/drm/xe/xe_tile.c            |  4 +-
 drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c  | 17 ++++----
 drivers/gpu/drm/xe/xe_ttm_stolen_mgr.h  |  2 +-
 11 files changed, 86 insertions(+), 130 deletions(-)

-- 
2.48.0



More information about the Intel-xe mailing list