[PATCH] drm/xe/guc: Don't allocate temporary policies object
Michal Wajdeczko
michal.wajdeczko at intel.com
Wed Jul 2 16:25:59 UTC 2025
On 02.07.2025 18:11, Matthew Brost wrote:
> On Wed, Jul 02, 2025 at 04:25:04PM +0200, Michal Wajdeczko wrote:
>> Since we are already using reusable buffer objects from the GuC
>> buffer cache, we can directly write into their CPU pointers and
>> spare unnecessary temporary allocation.
>>
>> While around, also make sure to clear obtained buffer, to avoid
>> sending some stale data.
>>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>> Cc: Matthew Brost <matthew.brost at intel.com>
>
> Patch LGTM:
> Reviewed-by: Matthew Brost <matthew.brost at intel.com>
>
> QQ semi-related though - guc_ads_action_update_policies. The GGTT
> address passed in is 32 bits. I thought the GuC firmware interface
> changed everywhere to use 64 bit GGTT addresses to future proof. Did
> this H2G get missed?
dunno, I was not included in any non-SRIOV GuC ABI reviews
but I guess we can still add new action (minor ABI change) that just
will be a new baseline for any future platform with 64b GGTT, no?
More information about the Intel-xe
mailing list