[PATCH 12/20] drm/i915/dp: Reprobe connector if getting/acking link service IRQs fails

Luca Coelho luca at coelho.fi
Thu Jul 3 11:37:33 UTC 2025


On Thu, 2025-06-26 at 11:20 +0300, Imre Deak wrote:
> From: Imre Deak <imre.deak at gmail.com>
> 
> An AUX access failure during HPD IRQ handling should be handled by
> falling back to a full connector detection, ensure that if the failure
> happens while reading/acking a link service IRQ.
> 
> Signed-off-by: Imre Deak <imre.deak at gmail.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 7eb208d2c321b..66db426b4aca1 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -5430,12 +5430,15 @@ static bool intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
>  		return false;
>  
>  	if (drm_dp_dpcd_readb(&intel_dp->aux,
> -			      DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
> +			      DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1)
> +		return true;
> +
> +	if (!val)
>  		return false;
>  
>  	if (drm_dp_dpcd_writeb(&intel_dp->aux,
>  			       DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
> -		return false;
> +		return true;
>  
>  	if (val & RX_CAP_CHANGED)
>  		reprobe_needed = true;

Reviewed-by: Luca Coelho <luciano.coelho at intel.com>

--
Cheers,
Luca.


More information about the Intel-xe mailing list