✗ CI.checkpatch: warning for LMTT invalidation (rev3)
Patchwork
patchwork at emeril.freedesktop.org
Thu Jul 3 14:23:49 UTC 2025
== Series Details ==
Series: LMTT invalidation (rev3)
URL : https://patchwork.freedesktop.org/series/151092/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
f8ff75ae1d2127635239b134695774ed4045d05b
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit b8b96ddb7a331d28b806c1af235b0e0ed94a9d85
Author: Michal Wajdeczko <michal.wajdeczko at intel.com>
Date: Thu Jul 3 00:30:41 2025 +0200
drm/xe/pf: Invalidate LMTT after completing changes
Once we finish populating all leaf pages in the VF's LMTT we should
make sure that hardware will not access any stale data. Explicitly
force LMTT invalidation (as it was already planned in the past).
Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
Cc: Michał Winiarski <michal.winiarski at intel.com>
Cc: Piotr Piórkowski <piotr.piorkowski at intel.com>
+ /mt/dim checkpatch d04a54cd3b99001adbc4cd3305b44f9f3e658407 drm-intel
0f7d90616af0 drm/xe/pf: Force GuC virtualization mode
-:17: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#17:
[ ] xe 0000:4d:00.0: [drm] *ERROR* GT0: FAST_REQ H2G fence 0x804e failed! e=0x30, h=0
total: 0 errors, 1 warnings, 0 checks, 52 lines checked
732ec78abc69 drm/xe/pf: Invalidate LMTT during LMEM unprovisioning
-:25: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#25: FILE: drivers/gpu/drm/xe/xe_device.h:134:
+#define for_each_gt_on_tile(gt__, tile__, id__) \
+ for_each_gt((gt__), (tile__)->xe, (id__)) \
+ for_each_if((gt__)->tile == (tile__))
BUT SEE:
do {} while (0) advice is over-stated in a few situations:
The more obvious case is macros, like MODULE_PARM_DESC, invoked at
file-scope, where C disallows code (it must be in functions). See
$exceptions if you have one to add by name.
More troublesome is declarative macros used at top of new scope,
like DECLARE_PER_CPU. These might just compile with a do-while-0
wrapper, but would be incorrect. Most of these are handled by
detecting struct,union,etc declaration primitives in $exceptions.
Theres also macros called inside an if (block), which "return" an
expression. These cannot do-while, and need a ({}) wrapper.
Enjoy this qualification while we work to improve our heuristics.
-:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt__' - possible side-effects?
#25: FILE: drivers/gpu/drm/xe/xe_device.h:134:
+#define for_each_gt_on_tile(gt__, tile__, id__) \
+ for_each_gt((gt__), (tile__)->xe, (id__)) \
+ for_each_if((gt__)->tile == (tile__))
-:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tile__' - possible side-effects?
#25: FILE: drivers/gpu/drm/xe/xe_device.h:134:
+#define for_each_gt_on_tile(gt__, tile__, id__) \
+ for_each_gt((gt__), (tile__)->xe, (id__)) \
+ for_each_if((gt__)->tile == (tile__))
total: 1 errors, 0 warnings, 2 checks, 138 lines checked
b8b96ddb7a33 drm/xe/pf: Invalidate LMTT after completing changes
More information about the Intel-xe
mailing list