✗ CI.checkpatch: warning for series starting with [1/2] drm/gem: Fix race in drm_gem_handle_create_tail()

[Patchwork]

== Series Details ==

Series: series starting with [1/2] drm/gem: Fix race in drm_gem_handle_create_tail()
URL   : https://patchwork.freedesktop.org/series/151277/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
43254c2aa575037fc031c7ac21b0d031c700b2bf
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit a6f059bb38b55ab1093db48ca6a75d6261a5bc53
Author: Simona Vetter <simona.vetter at ffwll.ch>
Date:   Mon Jul 7 17:18:14 2025 +0200

    drm/panthor: Fix UAF in panthor_gem_create_with_handle() debugfs code
    
    The object is potentially already gone after the drm_gem_object_put().
    In general the object should be fully constructed before calling
    drm_gem_handle_create(), except the debugfs tracking uses a separate
    lock and list and separate flag to denotate whether the object is
    actually initilized.
    
    Since I'm touching this all anyway simplify this by only adding the
    object to the debugfs when it's ready for that, which allows us to
    delete that separate flag. panthor_gem_debugfs_bo_rm() already checks
    whether we've actually been added to the list or this is some error
    path cleanup.
    
    v2: Fix build issues for !CONFIG_DEBUGFS (Adrián)
    
    Fixes: a3707f53eb3f ("drm/panthor: show device-wide list of DRM GEM objects over DebugFS")
    Cc: Adrián Larumbe <adrian.larumbe at collabora.com>
    Cc: Boris Brezillon <boris.brezillon at collabora.com>
    Cc: Steven Price <steven.price at arm.com>
    Cc: Liviu Dudau <liviu.dudau at arm.com>
    Signed-off-by: Simona Vetter <simona.vetter at intel.com>
    Signed-off-by: Simona Vetter <simona.vetter at ffwll.ch>
+ /mt/dim checkpatch 17e70ec7d93c01d943dba448b407ec3dc74e3ea7 drm-intel
77af43fa99d5 drm/gem: Fix race in drm_gem_handle_create_tail()
-:42: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit f6cd7daecff5 ("drm: Release driver references to handle before making it available again")'
#42: 
Note that the close-side of this race was fixed in f6cd7daecff5 ("drm:

-:73: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#73: 
Reported-by: Jacek Lawrynowicz <jacek.lawrynowicz at linux.intel.com>
Tested-by: Jacek Lawrynowicz <jacek.lawrynowicz at linux.intel.com>

-:116: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "obj"
#116: FILE: drivers/gpu/drm/drm_gem.c:466:
+	WARN_ON(obj != NULL);

-:134: WARNING:MISSING_FIXES_TAG: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag?

total: 1 errors, 2 warnings, 1 checks, 37 lines checked
a6f059bb38b5 drm/panthor: Fix UAF in panthor_gem_create_with_handle() debugfs code
-:14: WARNING:TYPO_SPELLING: 'initilized' may be misspelled - perhaps 'initialized'?
#14: 
actually initilized.
         ^^^^^^^^^^

-:46: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#46: FILE: drivers/gpu/drm/panthor/panthor_gem.c:23:
+}
+static void panthor_gem_debugfs_bo_add(struct panthor_gem_object *bo)

total: 0 errors, 1 warnings, 1 checks, 91 lines checked