[PATCH v8 2/7] drm/xe: Rename utilisation workaround emission function

Lucas De Marchi lucas.demarchi at intel.com
Tue Jul 8 22:14:06 UTC 2025


On Thu, Jul 03, 2025 at 09:20:54AM +0100, Tvrtko Ursulin wrote:
>Lucas suggested to consolidate to a slightly different naming scheme which
>will align with the upcoming additions better.
>
>Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
>Suggested-by: Lucas De Marchi <lucas.demarchi at intel.com>
>Cc: Matt Roper <matthew.d.roper at intel.com>
>---
> drivers/gpu/drm/xe/xe_lrc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
>index 5b05a730a0f2..edd8751b164a 100644
>--- a/drivers/gpu/drm/xe/xe_lrc.c
>+++ b/drivers/gpu/drm/xe/xe_lrc.c
>@@ -944,8 +944,9 @@ static void xe_lrc_finish(struct xe_lrc *lrc)
>  * store it in the PPHSWP.
>  */
> #define CONTEXT_ACTIVE 1ULL
>-static ssize_t wa_bb_setup_utilization(struct xe_lrc *lrc, struct xe_hw_engine *hwe,
>-				       u32 *batch, size_t max_len)
>+static ssize_t
>+setup_utilization_wa(struct xe_lrc *lrc, struct xe_hw_engine *hwe, u32 *batch,

almos this entire file uses the style like

static ssize_t setup_utilization_wa()...

with the return type in the same line. Let's keep it like that. Also, in
the commit message s/utilisation/utilization/ because that's what
matches the code change.

With that, Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi


>+		     size_t max_len)
> {
> 	u32 *cmd = batch;
>
>@@ -1038,7 +1039,7 @@ finish_bo(struct xe_lrc *lrc, unsigned int offset, u32 *cmd, u32 *free)
> static int setup_wa_bb(struct xe_lrc *lrc, struct xe_hw_engine *hwe)
> {
> 	static const struct bo_setup funcs[] = {
>-		{ .setup = wa_bb_setup_utilization },
>+		{ .setup = setup_utilization_wa },
> 	};
> 	unsigned int offset = __xe_lrc_wa_bb_offset(lrc);
> 	u32 *cmd, *buf = NULL;
>-- 
>2.48.0
>


More information about the Intel-xe mailing list